Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email template for the draft proposal reminder feature #1424

Open
plaindocs opened this issue Feb 6, 2023 · 3 comments
Open

Email template for the draft proposal reminder feature #1424

plaindocs opened this issue Feb 6, 2023 · 3 comments
Labels
size: regular The average issue stage: wip This issue is being worked on type: feature

Comments

@plaindocs
Copy link

Problem and impact

I want to write the template in advance, not make up the email on the fly.

Proposed solution / feature

No response

Context or examples

No response

@rixx rixx changed the title Email template for the reminder feature Email template for the draft proposal reminder feature Jul 13, 2023
@rixx
Copy link
Member

rixx commented Nov 16, 2023

Yeah, this would be good to have.

As internally, built-in email templates are handled very annoyingly, adding this will probably prompt a rewrite of that system. Just dumping my thoughts here for future reference:

  • add a MailTemplate.role field, nullable, possible values: submission.new (the ack template), submission.new.internal, submission.accept, submission.reject, question.reminder, submission.draft.reminder (actually, this will be a regular custom template, I think, so you can use multiple/different ones), schedule.new
  • Add a uniqueness constraint (event, role), so that each template can only exist once per event
  • Migrate existing event template data, turn ack_template etc into properties
  • Make sure forms, cloning etc still work
  • Group templates into built-in and custom ones for less scrolling / easier finding of custom email templates
  • Add get_builtin_placeholder method that returns extra allowed placeholders for built-in templates
  • Make template selectable in draft reminder email form
  • make sure the template can't be used in the regular sendmail form

@rixx rixx added size: regular The average issue stage: wip This issue is being worked on labels Nov 16, 2023
@rixx
Copy link
Member

rixx commented Dec 3, 2024

All this stuff is now done, so it’s only a matter of a) building a template select into the draft proposal form, or b) creating a new template type, "draft proposal reminder".

@plaindocs
Copy link
Author

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: regular The average issue stage: wip This issue is being worked on type: feature
Projects
None yet
Development

No branches or pull requests

2 participants