Skip to content

Remove references to plotly.js CDN and requirejs #4762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
marthacryan wants to merge 6 commits into from
Closed

Remove references to plotly.js CDN and requirejs #4762

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
08a175d
Remove references to plotly.js CDN
marthacryan Sep 11, 2024
3a8bf77
Remove cdn option for include_plotlyjs
marthacryan Sep 11, 2024
ebd482a
Remove requirejs
marthacryan Sep 11, 2024
e2cfbf6
Update comments describing the type of include_plotlyjs
marthacryan Sep 11, 2024
c0205a1
Remove old tests
marthacryan Sep 11, 2024
4a67af4
Remove references to cdn assertion function
marthacryan Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove old tests
  • Loading branch information
@marthacryan
marthacryan committed Sep 11, 2024
commit c0205a1f344559c402a31e08290beda38a52aa29
24 changes: 0 additions & 24 deletions packages/python/plotly/plotly/tests/test_core/test_offline/test_offline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,30 +161,6 @@ def test_including_plotlyjs_false_div(self):
self.assertNotIn(PLOTLYJS, html)
self.assertNotIn(directory_script, html)

def test_including_plotlyjs_cdn_html(self):
for include_plotlyjs in ["cdn", "CDN", "Cdn"]:
html = self._read_html(
plotly.offline.plot(
fig,
include_plotlyjs=include_plotlyjs,
output_type="file",
filename=html_filename,
auto_open=False,
)
)
self.assertIn(plotly_config_script, html)
self.assertNotIn(PLOTLYJS, html)
self.assertNotIn(directory_script, html)

def test_including_plotlyjs_cdn_div(self):
for include_plotlyjs in ["cdn", "CDN", "Cdn"]:
html = plotly.offline.plot(
fig, include_plotlyjs=include_plotlyjs, output_type="div"
)
self.assertIn(plotly_config_script, html)
self.assertNotIn(PLOTLYJS, html)
self.assertNotIn(directory_script, html)

def test_including_plotlyjs_directory_html(self):
self.assertFalse(os.path.exists(os.path.join(here, "plotly.min.js")))

Expand Down