Remove references to plotly.js CDN

Latest plotly.js used to be on a CDN, but it isn't anymore.
plotly · marthacryan · Sep 11, 2024 · Sep 11, 2024 · Sep 11, 2024 · Sep 11, 2024
commit 08a175dbdb077f683b3ffe08aa83dbad70079147
diff --git a/packages/python/plotly/plotly/io/_base_renderers.py b/packages/python/plotly/plotly/io/_base_renderers.py
@@ -8,7 +8,6 @@
 from plotly import utils, optional_imports
 from plotly.io import to_json, to_image, write_image, write_html
 from plotly.io._orca import ensure_server
-from plotly.io._utils import plotly_cdn_url
 from plotly.offline.offline import _get_jconfig, get_plotlyjs
 from plotly.tools import return_figure_from_figure_or_data
 
@@ -286,11 +285,6 @@ def activate(self):
         {mathjax_config}
         if (typeof require !== 'undefined') {{
         require.undef("plotly");
-        requirejs.config({{
-            paths: {{
-                'plotly': ['{plotly_cdn}']
-            }}
-        }});
         require(['plotly'], function(Plotly) {{
             window._Plotly = Plotly;
         }});
@@ -299,7 +293,6 @@ def activate(self):
         """.format(
                     win_config=_window_plotly_config,
                     mathjax_config=_mathjax_config,
-                    plotly_cdn=plotly_cdn_url().rstrip(".js"),
                 )
 
             else:

diff --git a/packages/python/plotly/plotly/io/_html.py b/packages/python/plotly/plotly/io/_html.py
@@ -3,7 +3,7 @@
 import webbrowser
 
 from _plotly_utils.optional_imports import get_module
-from plotly.io._utils import validate_coerce_fig_to_dict, plotly_cdn_url
+from plotly.io._utils import validate_coerce_fig_to_dict
 from plotly.offline.offline import _get_jconfig, get_plotlyjs
 
 _json = get_module("json")
@@ -270,9 +270,8 @@ def to_html(
     elif include_plotlyjs == "cdn":
         load_plotlyjs = """\
         {win_config}
-        <script charset="utf-8" src="{cdn_url}"></script>\
     """.format(
-            win_config=_window_plotly_config, cdn_url=plotly_cdn_url()
+            win_config=_window_plotly_config
         )
 
     elif include_plotlyjs == "directory":

diff --git a/packages/python/plotly/plotly/io/_utils.py b/packages/python/plotly/plotly/io/_utils.py
@@ -41,10 +41,3 @@ def validate_coerce_output_type(output_type):
     Must be one of: 'Figure', 'FigureWidget'"""
         )
     return cls
-
-
-def plotly_cdn_url(cdn_ver=get_plotlyjs_version()):
-    """Return a valid plotly CDN url."""
-    return "https://cdn.plot.ly/plotly-{cdn_ver}.min.js".format(
-        cdn_ver=cdn_ver,
-    )
diff --git a/packages/python/plotly/plotly/tests/test_core/test_offline/test_offline.py b/packages/python/plotly/plotly/tests/test_core/test_offline/test_offline.py
@@ -9,7 +9,6 @@
 
 import plotly
 import plotly.io as pio
-from plotly.io._utils import plotly_cdn_url
 
 packages_root = os.path.dirname(
     os.path.dirname(os.path.dirname(os.path.dirname(os.path.realpath(plotly.__file__))))
@@ -36,9 +35,6 @@
 <script type="text/javascript">\
 window.PlotlyConfig = {MathJaxConfig: 'local'};</script>"""
 
-cdn_script = '<script charset="utf-8" src="{cdn_url}"></script>'.format(
-    cdn_url=plotly_cdn_url()
-)
 
 directory_script = '<script charset="utf-8" src="plotly.min.js"></script>'
 
@@ -124,7 +120,6 @@ def test_including_plotlyjs_truthy_html(self):
 
             self.assertIn(plotly_config_script, html)
             self.assertIn(PLOTLYJS, html)
-            self.assertNotIn(cdn_script, html)
             self.assertNotIn(directory_script, html)
 
     def test_including_plotlyjs_truthy_div(self):
@@ -137,7 +132,6 @@ def test_including_plotlyjs_truthy_div(self):
 
             self.assertIn(plotly_config_script, html)
             self.assertIn(PLOTLYJS, html)
-            self.assertNotIn(cdn_script, html)
             self.assertNotIn(directory_script, html)
 
     def test_including_plotlyjs_false_html(self):
@@ -156,7 +150,6 @@ def test_including_plotlyjs_false_html(self):
 
             self.assertNotIn(plotly_config_script, html)
             self.assertNotIn(PLOTLYJS, html)
-            self.assertNotIn(cdn_script, html)
             self.assertNotIn(directory_script, html)
 
     def test_including_plotlyjs_false_div(self):
@@ -166,7 +159,6 @@ def test_including_plotlyjs_false_div(self):
             )
             self.assertNotIn(plotly_config_script, html)
             self.assertNotIn(PLOTLYJS, html)
-            self.assertNotIn(cdn_script, html)
             self.assertNotIn(directory_script, html)
 
     def test_including_plotlyjs_cdn_html(self):
@@ -182,7 +174,6 @@ def test_including_plotlyjs_cdn_html(self):
             )
             self.assertIn(plotly_config_script, html)
             self.assertNotIn(PLOTLYJS, html)
-            self.assertIn(cdn_script, html)
             self.assertNotIn(directory_script, html)
 
     def test_including_plotlyjs_cdn_div(self):
@@ -192,7 +183,6 @@ def test_including_plotlyjs_cdn_div(self):
             )
             self.assertIn(plotly_config_script, html)
             self.assertNotIn(PLOTLYJS, html)
-            self.assertIn(cdn_script, html)
             self.assertNotIn(directory_script, html)
 
     def test_including_plotlyjs_directory_html(self):
@@ -209,7 +199,6 @@ def test_including_plotlyjs_directory_html(self):
             )
             self.assertIn(plotly_config_script, html)
             self.assertNotIn(PLOTLYJS, html)
-            self.assertNotIn(cdn_script, html)
             self.assertIn(directory_script, html)
 
         # plot creates plotly.min.js in the output directory
@@ -230,7 +219,6 @@ def test_including_plotlyjs_directory_div(self):
 
             self.assertIn(plotly_config_script, html)
             self.assertNotIn(PLOTLYJS, html)
-            self.assertNotIn(cdn_script, html)
             self.assertIn(directory_script, html)
 
         # plot does NOT create a plotly.min.js file in the output directory
@@ -257,7 +245,6 @@ def test_including_plotlyjs_path_html(self):
                 )
             )
             self.assertNotIn(PLOTLYJS, html)
-            self.assertNotIn(cdn_script, html)
             self.assertNotIn(directory_script, html)
             self.assertIn(include_plotlyjs, html)
 
@@ -275,7 +262,6 @@ def test_including_plotlyjs_path_div(self):
                 fig, include_plotlyjs=include_plotlyjs, output_type="div"
             )
             self.assertNotIn(PLOTLYJS, html)
-            self.assertNotIn(cdn_script, html)
             self.assertNotIn(directory_script, html)
             self.assertIn(include_plotlyjs, html)
 

diff --git a/packages/python/plotly/plotly/tests/test_io/test_html.py b/packages/python/plotly/plotly/tests/test_io/test_html.py
@@ -6,7 +6,6 @@
 
 import plotly.graph_objs as go
 import plotly.io as pio
-from plotly.io._utils import plotly_cdn_url
 
 
 if sys.version_info >= (3, 3):
@@ -36,10 +35,6 @@ def fig1(request):
 # ----
 
 
-def test_versioned_cdn_included(fig1):
-    assert plotly_cdn_url() in pio.to_html(fig1, include_plotlyjs="cdn")
-
-
 def test_html_deterministic(fig1):
     div_id = "plotly-root"
     assert pio.to_html(fig1, include_plotlyjs="cdn", div_id=div_id) == pio.to_html(

diff --git a/packages/python/plotly/plotly/tests/test_io/test_renderers.py b/packages/python/plotly/plotly/tests/test_io/test_renderers.py
@@ -12,7 +12,6 @@
 import plotly.graph_objs as go
 import plotly.io as pio
 from plotly.offline import get_plotlyjs
-from plotly.io._utils import plotly_cdn_url
 
 if sys.version_info >= (3, 3):
     import unittest.mock as mock
@@ -137,10 +136,6 @@ def assert_not_full_html(html):
     assert not html.startswith("<html")
 
 
-def assert_html_renderer_connected(html):
-    assert plotly_cdn_url().rstrip(".js") in html
-
-
 def assert_offline(html):
     assert get_plotlyjs() in html
 
@@ -312,9 +307,7 @@ def test_repr_html(renderer):
     template = (
         '<div>                        <script type="text/javascript">'
         "window.PlotlyConfig = {MathJaxConfig: 'local'};</script>\n        "
-        '<script charset="utf-8" src="'
-        + plotly_cdn_url()
-        + '"></script>                '
+        '<script charset="utf-8" src="' + '"></script>                '
         '<div id="cd462b94-79ce-42a2-887f-2650a761a144" class="plotly-graph-div" '
         'style="height:100%; width:100%;"></div>            <script type="text/javascript">'
         "                                    window.PLOTLYENV=window.PLOTLYENV || {};"