Skip to content

Refactor title and subtitle selection in drawMainTitle function to use scoped selector #7522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gvwilson merged 4 commits into from
Aug 22, 2025
Merged

Refactor title and subtitle selection in drawMainTitle function to use scoped selector #7522

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
727f913
Refactor title and subtitle selection in drawMainTitle function to us…
davibarbosa2 Aug 15, 2025
0b1d6c9
Update draftlog for PR #7522
davibarbosa2 Aug 15, 2025
bc80967
Add test for title automargins in multiple plots
davibarbosa2 Aug 15, 2025
e8434c8
Enhance createGraphDiv function to accept a customizable divId parame…
davibarbosa2 Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add test for title automargins in multiple plots
  • Loading branch information
@davibarbosa2
davibarbosa2 committed Aug 15, 2025
commit bc8096798247b5893e6d412e834c2f207382cec1
43 changes: 43 additions & 0 deletions test/jasmine/tests/titles_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ var Lib = require('../../../src/lib');
var rgb = require('../../../src/components/color').rgb;

var createGraphDiv = require('../assets/create_graph_div');
var createShadowGraphDiv = require('../assets/create_shadow_graph_div');
var destroyGraphDiv = require('../assets/destroy_graph_div');
var mouseEvent = require('../assets/mouse_event');

Expand Down Expand Up @@ -980,6 +981,48 @@ describe('Title automargining', function() {
expect(gd._fullLayout._size.h).toBeCloseTo(243, -1);
}).then(done, done.fail);
});

it('computes title automargins independently when multiple plots exist', function(done) {
var gd1 = gd;
var gd2 = createShadowGraphDiv();

var dataLocal = [{x: [1, 2], y: [1, 2]}];

var layout1 = {
margin: {t: 0, b: 0, l: 0, r: 0},
height: 300,
width: 400,
title: {
text: 'Large title for plot 1',
font: {size: 36},
yref: 'paper',
automargin: true
}
};

var layout2 = {
margin: {t: 0, b: 0, l: 0, r: 0},
height: 300,
width: 400,
title: {
text: 'Small',
font: {size: 12},
yref: 'paper',
automargin: true
}
};

Plotly.newPlot(gd1, dataLocal, layout1)
.then(function() { return Plotly.newPlot(gd2, dataLocal, layout2); })
.then(function() {
// Each graph should compute its own top automargin from its own title bbox
var t1 = gd1._fullLayout._size.t;
var t2 = gd2._fullLayout._size.t;

expect(t1).toBeGreaterThan(t2);
})
.then(done, done.fail);
});
});

function expectTitle(expTitle) {
Expand Down