Skip to content

Refactor title and subtitle selection in drawMainTitle function to use scoped selector #7522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gvwilson merged 4 commits into from
Aug 22, 2025
Merged

Refactor title and subtitle selection in drawMainTitle function to use scoped selector #7522

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
727f913
Refactor title and subtitle selection in drawMainTitle function to us…
davibarbosa2 Aug 15, 2025
0b1d6c9
Update draftlog for PR #7522
davibarbosa2 Aug 15, 2025
bc80967
Add test for title automargins in multiple plots
davibarbosa2 Aug 15, 2025
e8434c8
Enhance createGraphDiv function to accept a customizable divId parame…
davibarbosa2 Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Refactor title and subtitle selection in drawMainTitle function to us… 
…e context-specific selection from the graph div (gd).
  • Loading branch information
@davibarbosa2
davibarbosa2 committed Aug 15, 2025
commit 727f913bfc861187c436f59c31f9a17bb12fca6f
6 changes: 3 additions & 3 deletions src/plot_api/subroutines.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,8 +428,8 @@ exports.drawMainTitle = function(gd) {
});

if(title.text && title.automargin) {
var titleObj = d3.selectAll('.gtitle');
var titleHeight = Drawing.bBox(d3.selectAll('.g-gtitle').node()).height;
var titleObj = d3.select(gd).selectAll('.gtitle');
var titleHeight = Drawing.bBox(d3.select(gd).selectAll('.g-gtitle').node()).height;
var pushMargin = needsMarginPush(gd, title, titleHeight);
if(pushMargin > 0) {
applyTitleAutoMargin(gd, y, pushMargin, titleHeight);
Expand All @@ -455,7 +455,7 @@ exports.drawMainTitle = function(gd) {
}

// If there is a subtitle
var subtitleObj = d3.selectAll('.gtitle-subtitle');
var subtitleObj = d3.select(gd).selectAll('.gtitle-subtitle');
if(subtitleObj.node()) {
// Get bottom edge of title bounding box
var titleBB = titleObj.node().getBBox();
Expand Down