Skip to content

Run noCI tests using GitHub workflows #7343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
archmoj merged 18 commits into from
Jun 5, 2025
Merged

Run noCI tests using GitHub workflows #7343

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
5872f73
change title to title.text in noCI tests
emilykl Jan 21, 2025
b8666d9
remove tests which use transforms
emilykl Jan 21, 2025
39520c1
run noCI tests in CI
emilykl Jan 21, 2025
6cc2ecc
Remove extra parameter from toBeCloseTo
marthacryan Jan 21, 2025
c006a90
remove error when in headless mode
marthacryan Jan 21, 2025
c610b60
Fix setting of title field
marthacryan Jan 21, 2025
a6dcc4f
Fix unsafe access of selectedData variable
marthacryan Jan 21, 2025
7c418a5
add margin of error to assertTextIsInsidePath
emilykl Jan 21, 2025
6cab6be
Merge branch 'fix-deprecated-tests' of https://github.com/plotly/plot…
emilykl Jan 21, 2025
8e0d77b
increase tolerance for zoom test
emilykl Jan 22, 2025
c71a251
add margin of error for funnel restyle test
emilykl Jan 22, 2025
659afc3
fix setting of title.text
emilykl Jan 22, 2025
af7d3cd
Remove test that checks for bug that no longer occurs
marthacryan Jan 24, 2025
3ec831c
Add different mapbox style url
marthacryan Jan 24, 2025
950ecd5
Merge remote-tracking branch 'origin/master' into fix-deprecated-tests
archmoj Jun 5, 2025
e4ef3f0
remove test/jasmine/tests/mapbox_test.js following #7355
archmoj Jun 5, 2025
1a7d399
only run jusmine tests - not the image test with orca
archmoj Jun 5, 2025
c79b348
adjust tests
archmoj Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add margin of error to assertTextIsInsidePath
  • Loading branch information
@emilykl
emilykl committed Jan 21, 2025
commit 7c418a50e8c52d1768d0f97c7becc883023efacc
12 changes: 6 additions & 6 deletions test/jasmine/tests/bar_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1195,14 +1195,14 @@ describe('A bar plot', function() {
return node.querySelectorAll('g.point');
}

function assertTextIsInsidePath(textNode, pathNode) {
function assertTextIsInsidePath(textNode, pathNode, errorMargin=0) {
var textBB = textNode.getBoundingClientRect();
var pathBB = pathNode.getBoundingClientRect();

expect(pathBB.left).not.toBeGreaterThan(textBB.left);
expect(textBB.right).not.toBeGreaterThan(pathBB.right);
expect(pathBB.top).not.toBeGreaterThan(textBB.top);
expect(textBB.bottom).not.toBeGreaterThan(pathBB.bottom);
expect(pathBB.left - errorMargin).not.toBeGreaterThan(textBB.left);
expect(textBB.right - errorMargin).not.toBeGreaterThan(pathBB.right);
expect(pathBB.top - errorMargin).not.toBeGreaterThan(textBB.top);
expect(textBB.bottom - errorMargin).not.toBeGreaterThan(pathBB.bottom);
}

function assertTextIsAbovePath(textNode, pathNode) {
Expand Down Expand Up @@ -1828,7 +1828,7 @@ describe('A bar plot', function() {
assertTextIsInsidePath(text03, path03); // inside
assertTextIsInsidePath(text12, path12); // inside
assertTextIsInsidePath(text20, path20); // inside
assertTextIsInsidePath(text30, path30); // inside
assertTextIsInsidePath(text30, path30, 0.5); // inside
})
.then(done, done.fail);
});
Expand Down