Compiler: replace parseForRequestor by checkNotice #13222
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few weeks ago, #13047 removed the notification ping pong of the compiler and replaced it by a single method
parseForRequestor
that callsparse
and catches its exceptions.Currently, thanks to #13084, #13165 and #13186, exceptions are nor more signaled during parsing and semantic analysis as the AST is annotated with warning and error information (RBNotices).
Therefore,
parseForRequestor
can now be replaced by something simpler that rely on AST notices instead of exceptions.