Faulty code: Make OCUndeclaredVariableWarning a little less special #13186
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does some cleanup and reorganization.
In #13165 it was explicitly noted that
OCASTSemanticAnalyzer
had to deal withOCUndeclaredVariableWarning
signaling in non-faulty-mode.This is bad because:
So this PR remove this responsibility on the semantic analyzer by making the Undeclared thing compatible with the RBNotice and CodeError infrastructure: it just annotates the AST; then possible
OCUndeclaredVariableWarning
are signaled along with possibleCodeError
.However, it does it transparently for existing clients, so preserving the current "half-warning half-error" semantic. (See #13006 )
Here is a summary on the changes:
Currently, it cannot be a subclass of CodeError because doing so breaks clients and tests that catch (or expect not to catch) CodeError exceptions.
As a side effect, OCSemanticWarning that is no more used is removed.