Skip to content

Add sock source for GPSD socket #1674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
davidv1992 merged 36 commits into from
Dec 5, 2024
Merged

Add sock source for GPSD socket #1674

davidv1992 merged 36 commits into from
Dec 5, 2024

Conversation

@michielp1807
Copy link
Contributor

@michielp1807 michielp1807 commented Oct 3, 2024

This PR builds on #1673 to add a sock time source for GPSD sockets.

The sock source can for example be configured as follows in the config file:

[[source]]
mode = "sock"
path = "/run/chrony.ttyAMA0.sock"
measurement_noise_estimate = 0.001

The NTP daemon will create the socket, which means that if you (re-)start GPSD, GPSD will send time data to us.

@michielp1807 michielp1807 force-pushed the sock-measurements branch 2 times, most recently from cb73865 to f3864c1 Compare October 3, 2024 14:50
@codecov
Copy link

codecov bot commented Oct 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 73.46939% with 182 lines in your changes missing coverage. Please review.

Project coverage is 81.45%. Comparing base (992a178) to head (9948ee3).
Report is 36 commits behind head on main.

Files with missing lines Patch % Lines
ntpd/src/daemon/system.rs 0.00% 51 Missing ⚠️
ntpd/src/daemon/sock_source.rs 83.84% 37 Missing ⚠️
ntpd/src/force_sync/algorithm.rs 0.00% 32 Missing ⚠️
ntp-proto/src/system.rs 55.81% 19 Missing ⚠️
ntpd/src/daemon/spawn/sock.rs 79.45% 15 Missing ⚠️
ntp-proto/src/source.rs 70.96% 9 Missing ⚠️
ntpd/src/daemon/spawn/mod.rs 57.89% 8 Missing ⚠️
ntp-proto/src/algorithm/kalman/source.rs 97.36% 4 Missing ⚠️
ntpd/src/daemon/config/mod.rs 0.00% 2 Missing ⚠️
ntpd/src/daemon/config/ntp_source.rs 71.42% 2 Missing ⚠️
... and 3 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1674      +/-   ##
==========================================
- Coverage   81.55%   81.45%   -0.11%     
==========================================
  Files          64       66       +2     
  Lines       20102    20508     +406     
==========================================
+ Hits        16394    16704     +310     
- Misses       3708     3804      +96

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidv1992 davidv1992 changed the base branch from main to observe-measurement-buffer October 17, 2024 11:35
@davidv1992 davidv1992 changed the base branch from observe-measurement-buffer to main October 17, 2024 11:35
@michielp1807 michielp1807 linked an issue Nov 28, 2024 that may be closed by this pull request
Implement support for the SOCK protocol #1632
Closed
davidv1992
davidv1992 previously approved these changes Nov 28, 2024
View reviewed changes
@davidv1992 davidv1992 enabled auto-merge November 28, 2024 13:03
@davidv1992 davidv1992 disabled auto-merge November 29, 2024 12:59
@michielp1807
Remove unused timestamps from measurements
7a17eb5 
(cherry picked from commit e44e3a6)
@michielp1807
Add constant measurement noise estimator
ee7a2ee 
(cherry picked from commit 0e3d4a4)
@michielp1807
Remove unused import from kalman source
2d76656 
(cherry picked from commit 5e56877)
@michielp1807
Clean up MeasurementNoiseEstimator
55a7c35 
(cherry picked from commit ac99d08)
@michielp1807
Fix bug causing AveragingBuffer not to update due to copy
2878cf9 
(cherry picked from commit 0a16d45)
@michielp1807
Fix clippy warning (use measurement.delay.map)
4bff945 
(cherry picked from commit aeb8024)
@michielp1807
Add noise estimator as parameter to add_source
fad6d11 
(cherry picked from commit 77fa89a)
@michielp1807
Use unreachable instead of tracing error
dca1c68 
(cherry picked from commit b473d93)
@michielp1807
Make measurements generic
3f6d835 
(cherry picked from commit ff30d36)
@michielp1807
Make Measurements public to make cargo happy
76054ab
@michielp1807
Add tests for measurements without delay
62c449b
@michielp1807
Refactor duplicate code
721136a
@michielp1807
Add sock source config
cee6eb0
@michielp1807
Add sock source
07ac513
@michielp1807
Clean up SourceCreateParameters
6fe7a4d
@michielp1807
Fix typo
59e880f
@michielp1807
Clean up duplicate create_source
1e38fb7
@michielp1807
Fix clippy warning (unnecessary format)
9640956
@michielp1807
Use constant noise estimator for sock source
04e4dd5
@davidv1992 davidv1992 added this pull request to the merge queue Dec 5, 2024
Merged via the queue into pendulum-project:main with commit 359bdf8 Dec 5, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidv1992 davidv1992 davidv1992 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement support for the SOCK protocol

2 participants

@michielp1807 @davidv1992