Allow measurements without delay #1673
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit e44e3a6)
(cherry picked from commit 0e3d4a4)
(cherry picked from commit 5e56877)
(cherry picked from commit ac99d08)
(cherry picked from commit 0a16d45)
(cherry picked from commit aeb8024)
(cherry picked from commit 77fa89a)
(cherry picked from commit b473d93)
(cherry picked from commit ff30d36)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1673 +/- ##
==========================================
- Coverage 81.33% 81.30% -0.03%
==========================================
Files 64 64
Lines 19751 19780 +29
==========================================
+ Hits 16065 16083 +18
- Misses 3686 3697 +11 ☔ View full report in Codecov by Sentry. |
davidv1992
requested changes
Oct 17, 2024
Member
davidv1992
left a comment
davidv1992
left a comment
There was a problem hiding this comment.
Some choices around type leaking that I don't agree with. The actual logic changes seem ok though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the
delayproperty of measurements to be eitherNtpDurationor(). If the delay is(), we use a constant value as the estimate of the measurement noise instead of an estimate based on the variance of delay values. This is useful for supporting alternative time sources, such as the SOCK protocol (#1632).The functions for creating a SOCK source are currently not covered by unit tests. I will add unit tests for these functions in a separate PR together with the actual implementation of the SOCK source.