chore: CR fixes #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: or-shachar <[email protected]>
gmwiz
reviewed
Nov 23, 2023
gmwiz
reviewed
Nov 23, 2023
gmwiz
reviewed
Nov 23, 2023
Signed-off-by: or-shachar <[email protected]>
or-shachar
force-pushed
the
review-fixes2
branch
from
b86bf60 to
73d4d85
Compare
gmwiz
approved these changes
Nov 24, 2023
cachers/disk.go
Outdated
| if err := os.Rename(tf.Name(), dest); err != nil { | ||
| os.Remove(tf.Name()) | ||
| defer func() { | ||
| _ = os.Remove(tempFile) |
There was a problem hiding this comment.
you only want to do this if err != nil, although this would work either way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After @gmwiz review on #5
Did not group imports - I'm using default IDE formatter