Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: CR fixes #6

Merged
merged 6 commits into from
Nov 23, 2023
Merged

chore: CR fixes #6

merged 6 commits into from
Nov 23, 2023

Conversation

or-shachar
Copy link
Owner

Fixing @dany74q CR #5

  1. Ordered functions using temporal order
  2. Separate channel for result and error
  3. Better handling of reading optional env variables
  4. Naming

dany74q
dany74q approved these changes Nov 23, 2023
View reviewed changes
cachers/combined.go Outdated Show resolved Hide resolved
cmd/go-cacher/cacher.go Outdated Show resolved Hide resolved
cmd/go-cacher/cacher.go Outdated Show resolved Hide resolved
cmd/go-cacher/cacher.go Outdated Show resolved Hide resolved
@or-shachar or-shachar merged commit b8df310 into main Nov 23, 2023
@or-shachar or-shachar mentioned this pull request Nov 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dany74q dany74q dany74q approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@or-shachar @dany74q