Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Change warning to error when incorrect type is used for mocking a resource #2220

Merged
merged 8 commits into from
Nov 28, 2024
Merged

Fix: Change warning to error when incorrect type is used for mocking a resource #2220

merged 8 commits into from
Nov 28, 2024
+50 −37

Conversation

ollevche
Copy link
Member

Resolves #1839 and continues work started in #1903 by @pooriaghaedi

Target Release

1.9.0

Checklist

  • I have read the contribution guide.
  • I have not used an AI coding assistant to create this PR.
  • I have written all code in this PR myself OR I have marked all code I have not written myself (including modified code, e.g. copied from other places and then modified) with a comment indicating where it came from.
  • I (and other contributors to this PR) have not looked at the Terraform source code while implementing this PR.

Go checklist

  • I have run golangci-lint on my change and receive no errors relevant to my code.
  • I have run existing tests to ensure my code doesn't break anything.
  • I have added tests for all relevant use cases of my code, and those tests are passing.
  • I have only exported functions, variables and structs that should be used from other packages.
  • I have added meaningful comments to all exported functions, variables, and structs.

pooriaghaedi and others added 7 commits November 27, 2024 11:21
@pooriaghaedi @ollevche
Fix: Change warning to error when incorrect type is used for mocking …
98f9f70 
…a resource (#1839)

Signed-off-by: pooriaghaedi <[email protected]>
@pooriaghaedi @ollevche
Fix: Change warning to error when incorrect type is used for mocking …
7ca0a44 
…a resource (#1839)

Signed-off-by: pooriaghaedi <[email protected]>
@pooriaghaedi @ollevche
Fix: Change warning to error when incorrect type is used for mocking …
075c563 
…a resource (#1839)

Signed-off-by: pooriaghaedi <[email protected]>
@pooriaghaedi @ollevche
Fix: Change warning to error when incorrect type is used for mocking …
55c8618 
…a resource (#1839)

Signed-off-by: pooriaghaedi <[email protected]>
@pooriaghaedi @ollevche
Update internal/configs/hcl2shim/mock_value_composer.go
bd0b3f0 
Co-authored-by: Oleksandr Levchenkov <[email protected]>
Signed-off-by: Pooria Ghaedi <[email protected]>
@ollevche
fix composer tests
e5390ac 
Signed-off-by: ollevche <[email protected]>
@ollevche
extend tests
efd7479 
Signed-off-by: ollevche <[email protected]>
@ollevche ollevche requested a review from a team as a code owner November 27, 2024 12:45
@github-actions GitHub Actions
Copy link

Reminder for the PR assignee: If this is a user-visible change, please update the changelog as part of the PR.

@ollevche
add CHANGELOG entry
6bc863b 
Signed-off-by: ollevche <[email protected]>
@ollevche ollevche merged commit a117f86 into main Nov 28, 2024
13 checks passed
@ollevche ollevche deleted the fix-test-warnings branch November 28, 2024 12:22
@ollevche ollevche mentioned this pull request Nov 28, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abstractionfactory abstractionfactory Awaiting requested review from abstractionfactory

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Testing: When mocking a resource, wrong type for the resource field doesn't fail, simply ignores mock
3 participants
@ollevche @abstractionfactory @pooriaghaedi