@cam72cam Can you please assign it to me and also give me some directions?

Hey @pooriaghaedi!

Thank you for volunteering, I've assigned you. Please read the "I've been assigned an issue, now what?" section of the contribution guide before you begin working.

In mocks and overrides, we use MockValueComposer to generate resulting values. It is defined in hcl2shim package.

You can go through the diags creation in MockValueComposer's functions and make sure those diags have relevant Warning / Error types. Feel free to ask more questions!

Hi @ollevche,

I have tested the same code with v1.9.0-alpha1 version and I get the following response:

tests/my-test.tftest.hcl... fail
  run "test"... fail
╷
│ Warning: Ignored mock/override field `domain_validation_options`
│ 
│   with aws_acm_certificate.this,
│   on main.tf line 5, in resource "aws_acm_certificate" "this":
│    5: resource "aws_acm_certificate" "this" {
│ 
│ Values provided for override / mock must match resource fields types: set of object required, but received number.
│ 
│ (and one more similar warning elsewhere)
╵
╷
│ Error: Test assertion failed
│ 
│   on tests/my-test.tftest.hcl line 13, in run "test":
│   13:     condition = one(aws_acm_certificate.this.domain_validation_options) == 2
│     ├────────────────
│     │ aws_acm_certificate.this.domain_validation_options is empty set of object
│ 
│ domain validation options is empty?
╵

Failure! 0 passed, 1 failed.

Should we consider this as resolved or does it still need investigation?

Hey @pooriaghaedi, the test assertion fails because the condition has not been met. If you change the condition to check against the empty set of objects, it will succeed.

We want tofu to fail due to mismatched mock / override types, which currently results in a warning. We should also review other warnings in MockValueComposer and turn some of them into errors.