Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Fix some DashboardLayout bugs and make some docs examples more consis… #3905

Merged
merged 12 commits into from
Aug 9, 2024
Merged

[core] Fix some DashboardLayout bugs and make some docs examples more consis… #3905

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
cd5ce4b
Fix some DashboardLayout bugs and make some docs examples more consis…
apedroferreira Aug 7, 2024
e82b611
Merge remote-tracking branch 'upstream/master' into core-docs-fixes
apedroferreira Aug 7, 2024
33fe7c0
Merge remote-tracking branch 'upstream/master' into core-docs-fixes
apedroferreira Aug 9, 2024
126661a
Move example
apedroferreira Aug 9, 2024
b682fb5
Merge branch 'master' into core-docs-fixes
Janpot Aug 9, 2024
5658dc0
Add todos
apedroferreira Aug 9, 2024
412a7b8
ugh
apedroferreira Aug 9, 2024
cdc45a6
Make it clearer
apedroferreira Aug 9, 2024
634b330
Merge branch 'master' into core-docs-fixes
apedroferreira Aug 9, 2024
0cd37ed
Remove unneeded check
apedroferreira Aug 9, 2024
b93880f
Simplify more
apedroferreira Aug 9, 2024
b426317
More nit simplifications I have to stop
apedroferreira Aug 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add todos
  • Loading branch information
@apedroferreira
apedroferreira committed Aug 9, 2024
commit 5658dc02bbb7ddbdae6a513e1ad1fa8813d0521e
3 changes: 2 additions & 1 deletion docs/public/static/toolpad/marketing/nextjs-icon-svgrepo-com.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
7 changes: 6 additions & 1 deletion packages/toolpad-core/src/DashboardLayout/DashboardLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ const AppBar = styled(MuiAppBar)(({ theme }) => ({
borderStyle: 'solid',
borderColor: (theme.vars ?? theme).palette.divider,
boxShadow: 'none',
// TODO: Temporary fix to issue reported in https://github.com/mui/material-ui/issues/43244
left: 0,
zIndex: theme.zIndex.drawer + 1,
}));
Expand Down Expand Up @@ -382,7 +383,10 @@ function DashboardLayout(props: DashboardLayoutProps) {
return (
<Box sx={{ display: 'flex' }}>
<AppBar color="inherit" position="fixed">
<Toolbar sx={{ backgroundColor: 'inherit', width: '100vw' }}>
{
// TODO: Temporary fix to issue reported in https://github.com/mui/material-ui/issues/43244
}
<Toolbar sx={{ backgroundColor: 'inherit', minWidth: '100vw' }}>
<Box sx={{ display: { xs: 'block', md: 'none' } }}>
<Tooltip
title={`${isMobileNavigationOpen ? 'Close' : 'Open'} menu`}
Expand Down Expand Up @@ -470,6 +474,7 @@ function DashboardLayout(props: DashboardLayoutProps) {
component="main"
sx={{
flexGrow: 1,
// TODO: Temporary fix to issue reported in https://github.com/mui/material-ui/issues/43244
minWidth: { xs: isMobileNavigationOpen ? '100vw' : 'auto', md: 'auto' },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a comment to the github issue on mui core repository that tracks the issues with the responsive drawer demo.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raised the issue in mui/material-ui#43244 and added todo comments in 5658dc0

}}
>
Expand Down
Loading