[core] Fix some DashboardLayout bugs and make some docs examples more consis… #3905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: out-of-date
apedroferreira
commented
Aug 9, 2024
| import { AppProvider } from '@toolpad/core/AppProvider'; | ||
| import { DashboardLayout } from '@toolpad/core/DashboardLayout'; | ||
|
|
||
| const NAVIGATION = [ |
There was a problem hiding this comment.
Yeah it's adding all this boilerplate here too but this way it matches the other examples...
apedroferreira
commented
Aug 9, 2024
| <Toolbar /> | ||
| <div>{children}</div> | ||
| {children} |
There was a problem hiding this comment.
I guess we don't need a div here (unrelated though)
github-actions
bot
removed
the
PR: out-of-date
Janpot
reviewed
Aug 9, 2024
| component="main" | ||
| sx={{ | ||
| flexGrow: 1, | ||
| minWidth: { xs: isMobileNavigationOpen ? '100vw' : 'auto', md: 'auto' }, |
There was a problem hiding this comment.
Let's add a comment to the github issue on mui core repository that tracks the issues with the responsive drawer demo.
There was a problem hiding this comment.
Raised the issue in mui/material-ui#43244 and added todo comments in 5658dc0
Janpot
approved these changes
Aug 9, 2024
oliviertassinari
added
the
component: layout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issues mentioned here #3893 (comment):
100vwto set an explicit width)https://deploy-preview-3905--mui-toolpad-docs.netlify.app/toolpad
https://deploy-preview-3905--mui-toolpad-docs.netlify.app/toolpad/core/react-dashboard-layout/