CMake: Do not specify absolute paths but relative ones. #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bumping this as useful. Was just dealing with this. |
Vollstrecker
pushed a commit
to cmake-remake/zlib
that referenced
this pull request
Nov 30, 2024
superseeds madler#265
Vollstrecker
pushed a commit
to cmake-remake/zlib
that referenced
this pull request
Nov 30, 2024
superseeds madler#265 and madler#170
Vollstrecker
pushed a commit
to cmake-remake/zlib
that referenced
this pull request
Nov 30, 2024
superseeds madler#265 and madler#170 and part of madler#148
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(important for packaging with cpack)
"Relative paths are already relative to CMAKE_INSTALL_PREFIX by default"
http://cmake.3232098.n2.nabble.com/Getting-empty-package-with-CPack-td7589998.html
please note that I'm not a zlib contributor, so consider this PR as an advice only.