Cmake install fix #170
Open
Cmake install fix #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When these variables are set in the cache, changing the CMAKE_INSTALL_PREFIX does not change the directories that actually get used. Instead, use them if the user provided them via -D, otherwise use the default based on CMAKE_INSTALL_PREFIX.
zlib is a compile library and its .pc file should live in the library directory. This allows a 64bit zlib and a 32bit zlib to co-exist in the same install prefix.
mathstuf
commented
Dec 15, 2021
| set(INSTALL_MAN_DIR "${CMAKE_INSTALL_PREFIX}/share/man" CACHE PATH "Installation directory for manual pages") | ||
| set(INSTALL_PKGCONFIG_DIR "${CMAKE_INSTALL_PREFIX}/share/pkgconfig" CACHE PATH "Installation directory for pkgconfig (.pc) files") | ||
| if (NOT INSTALL_BIN_DIR) | ||
| set(INSTALL_BIN_DIR "${CMAKE_INSTALL_PREFIX}/bin") |
There was a problem hiding this comment.
Even better would be to remove ${CMAKE_INSTALL_PREFIX}/ here completely. CMake will add it at install time for any relative path.
Vollstrecker
pushed a commit
to cmake-remake/zlib
that referenced
this pull request
Nov 30, 2024
superseeds madler#265 and madler#170
Vollstrecker
pushed a commit
to cmake-remake/zlib
that referenced
this pull request
Nov 30, 2024
superseeds madler#265 and madler#170 and part of madler#148
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.