Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed log level to warning for 404 #445

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Changed log level to warning for 404 #445

merged 2 commits into from
Oct 8, 2024

Conversation

rakhiagr
Copy link
Contributor

@rakhiagr rakhiagr commented Oct 7, 2024

Summary

Changed log level to warning for 404 for BaseAspectRouting

Testing Done

./gradlew build

Checklist

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 67.54%. Comparing base (abfb659) to head (9cf6d9b).

Files with missing lines Patch % Lines
...din/metadata/restli/BaseAspectRoutingResource.java 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #445      +/-   ##
============================================
- Coverage     67.57%   67.54%   -0.04%     
  Complexity     1548     1548              
============================================
  Files           138      138              
  Lines          6082     6085       +3     
  Branches        659      660       +1     
============================================
  Hits           4110     4110              
- Misses         1693     1696       +3     
  Partials        279      279              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jsdonn jsdonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for making the change!

@rakhiagr rakhiagr merged commit 6cd913f into master Oct 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants