Changed log level to warning for 404 (#445)

* Changed log level to warning for 404 * Addressed comments --------- Co-authored-by: Rakhi Agrawal <[email protected]>
linkedin · Oct 8, 2024 · 6cd913f · 6cd913f
1 parent abfb659
commit 6cd913f
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/restli-resources/src/main/java/com/linkedin/metadata/restli/BaseAspectRoutingResource.java b/restli-resources/src/main/java/com/linkedin/metadata/restli/BaseAspectRoutingResource.java
@@ -43,6 +43,7 @@
 import static com.linkedin.metadata.dao.BaseReadDAO.*;
 import static com.linkedin.metadata.dao.utils.ModelUtils.*;
 import static com.linkedin.metadata.restli.RestliConstants.*;
+import static com.linkedin.restli.common.HttpStatus.*;
 
 
 /**
@@ -668,12 +669,15 @@ private BackfillResult backfillWithDefault(@Nonnull final Set<URN> urns, @Nonnul
   private List<? extends RecordTemplate> getValueFromRoutingGms(@Nonnull URN urn,
       Collection<Class<? extends RecordTemplate>> routeAspectClasses) {
     return routeAspectClasses.stream().map(routeAspectClass -> {
-
       try {
         return getAspectRoutingGmsClientManager().getRoutingGmsClient(routeAspectClass).get(urn);
-      } catch (Exception exception) {
-        log.error(String.format("Couldn't get routing aspect %s for %s", routeAspectClass.getSimpleName(), urn),
-            exception);
+      } catch (Exception e) {
+        String logMessage = String.format("Couldn't find routing aspect %s for %s", routeAspectClass.getSimpleName(), urn);
+        if (e instanceof RestLiServiceException && ((RestLiServiceException) e).getStatus() == S_404_NOT_FOUND) {
+         log.warn(logMessage, e);
+        } else {
+          log.error(logMessage, e);
+        }
         return null;
       }
     }).filter(Objects::nonNull).collect(Collectors.toList());