Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding PreUpdateRouting to BaseAspectRoutingResource #413

Merged
merged 13 commits into from
Sep 5, 2024
Merged

Adding PreUpdateRouting to BaseAspectRoutingResource #413

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
7c4e5fd
Adding PreUpdateRouting to BaseAspect
Sep 4, 2024
66b5b0a
Added a comment
Sep 4, 2024
99dd9ca
Update BaseAspectRoutingResource.java
rakhiagr Sep 4, 2024
70925b5
Added unit test
Sep 4, 2024
da1a988
Fixed return type
Sep 5, 2024
8a0ab62
Added protobuf
Sep 5, 2024
15cba9d
Fixed java doc
Sep 5, 2024
88fb61f
Fixed compilation error
Sep 5, 2024
924dac8
Addressed comments
Sep 5, 2024
e41bf73
Checkstyle error
Sep 5, 2024
643496f
Forgot to change at other place
Sep 5, 2024
e6e89d6
Using fqcn
Sep 5, 2024
2e98c3e
Updated unit tests
Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Updated unit tests
  • Loading branch information
Rakhi Agrawal committed Sep 5, 2024
commit 2e98c3e0334bb25918fa9e2a77881b7034c78327
8 changes: 4 additions & 4 deletions ...i-resources/src/test/java/com/linkedin/metadata/restli/BaseAspectRoutingResourceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,7 +560,7 @@ public void testPreUpdateRoutingWithRegisteredAspect() {
_resource.setRestliPreUpdateAspectRegistry(new SamplePreUpdateAspectRegistryImpl());
runAndWait(_resource.ingest(snapshot));
verify(_mockAspectFooGmsClient, times(1)).ingest(eq(urn), eq(bar));
verify(_mockLocalDAO, times(0)).add(eq(urn), eq(bar), any(), eq(null), eq(null));
verify(_mockLocalDAO, times(0)).add(any(), any(), any(), any(), any());
verifyNoMoreInteractions(_mockLocalDAO);
}

Expand All @@ -572,7 +572,7 @@ public void testPreUpdateRoutingWithNonRegisteredPreUpdateAspect() {
EntitySnapshot snapshot = ModelUtils.newSnapshot(EntitySnapshot.class, urn, aspects);
_resource.setRestliPreUpdateAspectRegistry(new SamplePreUpdateAspectRegistryImpl());
runAndWait(_resource.ingest(snapshot));
verify(_mockAspectBarGmsClient, times(0)).ingest(eq(urn), eq(bar));
verify(_mockAspectBarGmsClient, times(0)).ingest(any(), any());
verify(_mockLocalDAO, times(1)).add(eq(urn), eq(bar), any(), eq(null), eq(null));
verifyNoMoreInteractions(_mockLocalDAO);
}
Expand All @@ -596,8 +596,8 @@ public void testPreUpdateRoutingWithSkipIngestion() throws NoSuchFieldException,
EntitySnapshot snapshot = ModelUtils.newSnapshot(EntitySnapshot.class, urn, aspects);
_resource.setRestliPreUpdateAspectRegistry(new SamplePreUpdateAspectRegistryImpl());
runAndWait(_resource.ingest(snapshot));
verify(_mockAspectFooGmsClient, times(0)).ingest(eq(urn), eq(foo));
verify(_mockLocalDAO, times(0)).add(eq(urn), eq(foo), any(), eq(null), eq(null));
verify(_mockAspectFooGmsClient, times(0)).ingest(any(), any());
verify(_mockLocalDAO, times(0)).add(any(), any(), any(), any(), any());
}

}
Loading