Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding PreUpdateRouting to BaseAspectRoutingResource #413

Merged
merged 13 commits into from
Sep 5, 2024

Conversation

rakhiagr
Copy link
Contributor

@rakhiagr rakhiagr commented Sep 4, 2024

Summary

Adding PreUpdateRouting to BaseAspectRoutingResource

Testing Done

./gradlew build

Checklist

@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 67.57%. Comparing base (dc8ab8f) to head (2e98c3e).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...din/metadata/restli/BaseAspectRoutingResource.java 25.00% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #413      +/-   ##
============================================
+ Coverage     67.46%   67.57%   +0.11%     
- Complexity     1518     1522       +4     
============================================
  Files           137      137              
  Lines          5945     5953       +8     
  Branches        640      644       +4     
============================================
+ Hits           4011     4023      +12     
+ Misses         1663     1659       -4     
  Partials        271      271              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@JiaoMaWHU JiaoMaWHU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for addressing all the comments

@rakhiagr rakhiagr merged commit 794996a into master Sep 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants