Update release-1.11 branch to go1.11.5 #74430

ixdy · 2019-02-22T19:38:51Z

Cherry pick of #69386 #69939 #70665 #72035 #72084 #73326 on release-1.11.

This is my attempt to implement https://github.com/kubernetes/kubernetes/issues/73286 for release-1.11.

It touches a whole bunch of files largely because there were formatting and vet changes introduced in go1.11 (fixes coming from #69386). There may still be vet fixes needed; I'm running some checks now.

#69386: Bump rules_go to 0.15.4 to support go1.11.1
#69939: Clean cross-build image and update to protoc 3.0.2
#70665: Bump golang version to 1.11.2
#72035: bump golang to 1.11.3 (CVE-2018-16875)
#72084: Update to go1.11.4
#73326: Update to go1.11.5

/assign @BenTheElder @cblecker @dims @tpepper @foxish

/sig release
/priority important-longterm

pkg/controller/route/route_controller_test.go:101: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:102: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:105: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:106: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:118: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:121: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:122: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:135: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:136: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:148: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:149: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:150: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:151: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:154: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:155: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:167: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:168: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:171: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:172: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:185: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:197: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:198: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:199: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:202: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:203: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:215: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:216: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:217: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:220: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:221: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:222: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields

pkg/kubelet/kubelet_test.go:1573: *k8s.io/kubernetes/pkg/kubelet/container/testing.FakePod composite literal uses unkeyed fields

test/soak/cauldron/cauldron.go:106: Warningf format %e has arg ns of wrong type string

test/soak/serve_hostnames/serve_hostnames.go:124: Warningf format %e has arg ns of wrong type string

Signed-off-by: Eli Uriegas <[email protected]>

k8s-ci-robot · 2019-02-22T19:38:53Z

@ixdy: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2019-02-22T19:38:53Z

@ixdy: This PR is not for the master branch but does not have the cherry-pick-approved label. Adding the do-not-merge/cherry-pick-not-approved label.

To approve the cherry-pick, please assign the patch release manager for the release branch by writing /assign @username in a comment when ready.

The list of patch release managers for each release can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2019-02-22T19:39:46Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ixdy
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: lavalamp

If they are not already assigned, you can assign the PR to them by writing /assign @lavalamp in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~build/OWNERS~~ [ixdy]
cluster/OWNERS
cmd/cloud-controller-manager/OWNERS
cmd/kube-apiserver/OWNERS
cmd/kube-controller-manager/OWNERS
cmd/kubeadm/OWNERS
~~hack/OWNERS~~ [ixdy]
pkg/OWNERS
plugin/pkg/admission/OWNERS
staging/src/k8s.io/api/OWNERS
staging/src/k8s.io/apimachinery/pkg/OWNERS
staging/src/k8s.io/apiserver/OWNERS
staging/src/k8s.io/client-go/OWNERS
staging/src/k8s.io/code-generator/OWNERS
staging/src/k8s.io/kube-aggregator/OWNERS
~~test/OWNERS~~ [ixdy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2019-02-22T19:41:58Z

@ixdy: The following tests failed for commit 3c579bb, say /retest to rerun them:

Test name	Details	Rerun command
pull-kubernetes-typecheck	link	`/test pull-kubernetes-typecheck`
pull-kubernetes-bazel-build	link	`/test pull-kubernetes-bazel-build`
pull-kubernetes-bazel-test	link	`/test pull-kubernetes-bazel-test`
pull-kubernetes-kubemark-e2e-gce-big	link	`/test pull-kubernetes-kubemark-e2e-gce-big`
pull-kubernetes-e2e-gce-device-plugin-gpu	link	`/test pull-kubernetes-e2e-gce-device-plugin-gpu`
pull-kubernetes-integration	link	`/test pull-kubernetes-integration`
pull-kubernetes-e2e-gce	link	`/test pull-kubernetes-e2e-gce`
pull-kubernetes-verify	link	`/test pull-kubernetes-verify`
pull-kubernetes-node-e2e	link	`/test pull-kubernetes-node-e2e`
pull-kubernetes-cross	link	`/test pull-kubernetes-cross`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ixdy · 2019-02-22T19:44:16Z

ok, this is about as much of a 🔥 as I expected. I'll come back to this later.

BenTheElder · 2019-02-22T19:50:38Z

we'll need to bump the images in test-infra as well? then it should be less fire

k8s-ci-robot · 2019-04-01T20:49:46Z

@ixdy: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

fejta-bot · 2019-06-30T21:01:40Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

cblecker · 2019-06-30T22:36:24Z

I think we've dropped support for 1.11.
/close

k8s-ci-robot · 2019-06-30T22:36:25Z

@cblecker: Closed this PR.

In response to this:

I think we've dropped support for 1.11.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cblecker and others added 11 commits February 22, 2019 11:29

Bump golang version to 1.11.1

fd36bb7

Update gofmt for go1.11

11fcde5

fix vet error in pkg/kubelet/kubelet_test.go

b63a1fa

pkg/kubelet/kubelet_test.go:1573: *k8s.io/kubernetes/pkg/kubelet/container/testing.FakePod composite literal uses unkeyed fields

fix vet error in test/soak/cauldron/cauldron.go

6a3bd46

test/soak/cauldron/cauldron.go:106: Warningf format %e has arg ns of wrong type string

fix vet error in test/soak/serve_hostnames/serve_hostnames.go

43971ae

test/soak/serve_hostnames/serve_hostnames.go:124: Warningf format %e has arg ns of wrong type string

Clean cross-build image and update to protoc 3.0.2

0d631b3

Bump golang version to 1.11.2

6b71008

bump golang to 1.11.3 (CVE-2018-16875)

4680390

Signed-off-by: Eli Uriegas <[email protected]>

Update to go1.11.4

347dfd6

Update to go1.11.5

3c579bb

k8s-ci-robot requested review from andrewsykim and anguslees February 22, 2019 19:39

k8s-ci-robot added area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 22, 2019

k8s-ci-robot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Feb 22, 2019

k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 22, 2019

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 1, 2019

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 30, 2019

k8s-ci-robot closed this Jun 30, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update release-1.11 branch to go1.11.5 #74430

Update release-1.11 branch to go1.11.5 #74430

ixdy commented Feb 22, 2019 •

edited

Loading

k8s-ci-robot commented Feb 22, 2019

k8s-ci-robot commented Feb 22, 2019

k8s-ci-robot commented Feb 22, 2019

k8s-ci-robot commented Feb 22, 2019 •

edited

Loading

ixdy commented Feb 22, 2019 •

edited

Loading

BenTheElder commented Feb 22, 2019

k8s-ci-robot commented Apr 1, 2019

fejta-bot commented Jun 30, 2019

cblecker commented Jun 30, 2019

k8s-ci-robot commented Jun 30, 2019

Update release-1.11 branch to go1.11.5 #74430

Update release-1.11 branch to go1.11.5 #74430

Conversation

ixdy commented Feb 22, 2019 • edited Loading

k8s-ci-robot commented Feb 22, 2019

k8s-ci-robot commented Feb 22, 2019

k8s-ci-robot commented Feb 22, 2019

k8s-ci-robot commented Feb 22, 2019 • edited Loading

ixdy commented Feb 22, 2019 • edited Loading

BenTheElder commented Feb 22, 2019

k8s-ci-robot commented Apr 1, 2019

fejta-bot commented Jun 30, 2019

cblecker commented Jun 30, 2019

k8s-ci-robot commented Jun 30, 2019

ixdy commented Feb 22, 2019 •

edited

Loading

k8s-ci-robot commented Feb 22, 2019 •

edited

Loading

ixdy commented Feb 22, 2019 •

edited

Loading