Hi @seemethere. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

@seemethere Has the Docker Hub tag for golang:1.11.3 been pushed yet?

/assign cblecker ixdy
/uncc jbeda

We also need to bump the rules_go version. The new tags are in the referenced issue.

Yup images for amd64 were pushed around 3pm PST

yeah, can you please bump rules_go (in the WORKSPACE file) to 0.16.4?

@cblecker @ixdy just pushed with rules_go updated to 0.16.4

also test/images/Makefile?

we definitely specify the Go version in too many places :\

/ok-to-test

I'm working on building the crossbuild image now.

Updated the test image as well!

Yeah the GOLANG_VERSION should probably just be driven by a top level file

The cross-build image is failing to build:

Step 7/12 : RUN echo "deb http://archive.ubuntu.com/ubuntu xenial main universe" > /etc/apt/sources.list.d/cgocrosscompiling.list   && apt-key adv --keyserver keyserver.ubuntu.com --recv-keys 40976EAF437D05B5 3B4FE6ACC0B21F32   && apt-get update   && apt-get install -y build-essential   && for platform in ${KUBE_DYNAMIC_CROSSPLATFORMS}; do apt-get install -y crossbuild-essential-${platform}; done   && apt-get clean && rm -rf /var/lib/apt/lists/*
 ---> Running in 540f2d08fdbf
Warning: apt-key output should not be parsed (stdout is not a terminal)
Executing: /tmp/apt-key-gpghome.WdHS7PRkq5/gpg.1.sh --keyserver keyserver.ubuntu.com --recv-keys 40976EAF437D05B5 3B4FE6ACC0B21F32
gpg: cannot open '/dev/tty': No such device or address
The command '/bin/sh -c echo "deb http://archive.ubuntu.com/ubuntu xenial main universe" > /etc/apt/sources.list.d/cgocrosscompiling.list   && apt-key adv --keyserver keyserver.ubuntu.com --recv-keys 40976EAF437D05B5 3B4FE6ACC0B21F32   && apt-get update   && apt-get install -y build-essential   && for platform in ${KUBE_DYNAMIC_CROSSPLATFORMS}; do apt-get install -y crossbuild-essential-${platform}; done   && apt-get clean && rm -rf /var/lib/apt/lists/*' returned a non-zero code: 2
Makefile:24: recipe for target 'build' failed

I'm not sure what is wrong. I can't build cross-build:v1.11.2-1 anymore either, so I don't think it's related to this change.

aha, just found https://stackoverflow.com/questions/53371626/apt-key-command-works-on-shell-but-fails-on-dockerfile.

Can you add --no-tty to the apt-key command in the Dockerfile?

basically this:

diff --git a/build/build-image/cross/Dockerfile b/build/build-image/cross/Dockerfile
index 8e4bc0f884..70e42cf87e 100644
--- a/build/build-image/cross/Dockerfile
+++ b/build/build-image/cross/Dockerfile
@@ -44,7 +44,7 @@ RUN apt-get update \
 # Use dynamic cgo linking for architectures other than amd64 for the server platforms
 # To install crossbuild essential for other architectures add the following repository.
 RUN echo "deb http://archive.ubuntu.com/ubuntu xenial main universe" > /etc/apt/sources.list.d/cgocrosscompiling.list \
-  && apt-key adv --keyserver keyserver.ubuntu.com --recv-keys 40976EAF437D05B5 3B4FE6ACC0B21F32 \
+  && apt-key adv --no-tty --keyserver keyserver.ubuntu.com --recv-keys 40976EAF437D05B5 3B4FE6ACC0B21F32 \
   && apt-get update \
   && apt-get install -y build-essential \
   && for platform in ${KUBE_DYNAMIC_CROSSPLATFORMS}; do apt-get install -y crossbuild-essential-${platform}; done \

Have added the --no-tty flag

/retest

/lgtm
/priority important-soon

/approve

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ixdy, seemethere

The full list of commands accepted by this bot can be found here.

The pull request process is described here