fix azure disk attach/detach failed forever issue #71377
Merged
+10
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
sig/cloud-provider
Member
Author
|
@feiskyer can you mark this PR as important, thanks. |
k8s-ci-robot
added
release-note
Member
|
/priority critical-urgent Marked as v1.13 milestone since this is a critical urgent bug fix. |
k8s-ci-robot
added
the
priority/critical-urgent
k8s-ci-robot
added
lgtm
Member
Author
|
/test pull-kubernetes-integration |
1 similar comment
Contributor
|
/test pull-kubernetes-integration |
This was referenced Nov 26, 2018
ghost
mentioned this pull request
k8s-ci-robot
added a commit
that referenced
this pull request
Nov 27, 2018
…1377-upstream-release-1.10 Automated cherry pick of #71377: should return error when attach/detach failed
k8s-ci-robot
added a commit
that referenced
this pull request
Nov 28, 2018
…1377-upstream-release-1.12 Automated cherry pick of #71377: should return error when attach/detach failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
fix azure disk attach/detach failed forever issue
#70568 removes the retry operation of azure disk attach/detach, while it introduces a bug which could make azure disk attach/detach failed forever issue if first attach/detach failed
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #71344
Special notes for your reviewer:
In original code,
AttachandDetachfunction will always return nil no matter that attach/detach operation failed or not. It's a not-easy-to-find bug in code review...Release note:
/sig azure
/assign @feiskyer
@brendandburns @khenidak
cc @antoineco