remove retry operation on attach/detach azure disk #70568
Merged
+19
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
feiskyer
reviewed
Nov 2, 2018
feiskyer
reviewed
Nov 2, 2018
Member
|
/priority important-soon |
k8s-ci-robot
added
priority/important-soon
andyzhangx
force-pushed
the
remove-retry-azuredisk
branch
from
0d91adf to
c7acc7a
Compare
fix logging fix build failure
andyzhangx
force-pushed
the
remove-retry-azuredisk
branch
from
c7acc7a to
8abadbe
Compare
Contributor
|
code lgtm |
k8s-ci-robot
added
the
lgtm
This was referenced Nov 5, 2018
k8s-ci-robot
added a commit
that referenced
this pull request
Nov 8, 2018
…0568-upstream-release-1.12 Automated cherry pick of #70568: remove retry operation on attach/detach disk
k8s-ci-robot
added a commit
that referenced
this pull request
Nov 8, 2018
…0568-upstream-release-1.10 Automated cherry pick of #70568: remove retry operation on attach/detach disk
This was referenced Nov 23, 2018
k8s-ci-robot
added a commit
that referenced
this pull request
Dec 3, 2018
…0568-upstream-release-1.11 Automated cherry pick of #70568: remove retry operation on attach/detach disk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
remove retry operation on attach/detach azure disk, switch to use k8s attach-detach controller which would control retry attach/detach disk
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #70567
Special notes for your reviewer:
retry azure disk attach operation produce too many API calls
Now the default
cloudProviderBackoffRetriesvalue is 6 which means if AttachDisk operation failed, it will retry 6 more times, when disk quota is full on a VM, it produces too many API calls. Retry attach disk behavior is not necessary since it AttachVolume operation fails, k8s attachdetach-controller will retry once a minute until it succeeds.default setting in
/etc/kubernetes/azure.jsonnow:Does this PR introduce a user-facing change?:
Release note:
/sig azure
/assign @feiskyer
@jackfrancis @khenidak @brendandburns