Automated cherry pick of #49805 #50260

nbutton23 · 2017-08-07T17:23:30Z

Cherry pick of #49805 on release-1.7.

#49805: We never want to modify the globally defined SG

k8s-ci-robot · 2017-08-07T17:23:38Z

Hi @nbutton23. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

nbutton23 · 2017-08-07T18:07:35Z

/assign @zmerlynn

zmerlynn · 2017-08-07T21:39:09Z

/lgtm
/approve

k8s-github-robot · 2017-08-07T21:39:40Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nbutton23, zmerlynn

Associated issue: 49805

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these OWNERS Files:

~~pkg/cloudprovider/providers/aws/OWNERS~~ [zmerlynn]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

fejta-bot · 2017-08-09T13:28:28Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

k8s-ci-robot · 2017-08-09T13:28:42Z

@fejta-bot: you can't request testing unless you are a kubernetes member.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

fejta-bot · 2017-08-09T15:34:34Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

k8s-ci-robot · 2017-08-09T15:34:49Z

@fejta-bot: you can't request testing unless you are a kubernetes member.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

fejta-bot · 2017-08-09T18:01:55Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

k8s-ci-robot · 2017-08-09T18:02:09Z

@fejta-bot: you can't request testing unless you are a kubernetes member.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

fejta-bot · 2017-08-09T20:07:28Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

k8s-ci-robot · 2017-08-09T20:07:42Z

@fejta-bot: you can't request testing unless you are a kubernetes member.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

fejta-bot · 2017-08-09T22:13:33Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

k8s-ci-robot · 2017-08-09T22:13:47Z

@fejta-bot: you can't request testing unless you are a kubernetes member.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

fejta-bot · 2017-08-10T00:19:28Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

k8s-ci-robot · 2017-08-10T00:19:41Z

@fejta-bot: you can't request testing unless you are a kubernetes member.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

fejta-bot · 2017-08-10T02:25:27Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

k8s-ci-robot · 2017-08-10T02:25:41Z

@fejta-bot: you can't request testing unless you are a kubernetes member.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

fejta-bot · 2017-08-10T04:31:30Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

k8s-ci-robot · 2017-08-10T04:31:44Z

@fejta-bot: you can't request testing unless you are a kubernetes member.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

fejta-bot · 2017-08-10T06:37:29Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

k8s-ci-robot · 2017-08-10T06:37:43Z

@fejta-bot: you can't request testing unless you are a kubernetes member.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nbutton23 · 2017-08-10T14:40:16Z

@zmerlynn is there something that can be done to stop the bots from dueling every 2 hours?

wojtek-t · 2017-08-11T06:30:42Z

/retest

nbutton23 · 2017-08-11T23:58:36Z

/test pull-kubernetes-federation-e2e-gce

k8s-ci-robot · 2017-08-11T23:58:50Z

@nbutton23: you can't request testing unless you are a kubernetes member.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nbutton23 · 2017-08-12T00:05:25Z

Looks like my commit was merged in a different PR. #50307

wojtek-t · 2017-08-12T10:52:22Z

No - that PR wasn't merged.

wojtek-t · 2017-08-12T10:52:29Z

/retest

k8s-github-robot · 2017-08-12T11:42:01Z

/test all [submit-queue is verifying that this PR is safe to merge]

k8s-github-robot · 2017-08-12T12:44:18Z

Automatic merge from submit-queue

We never want to modify the globally defined SG

b5a07f5

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 7, 2017

k8s-github-robot assigned gnufied and zmerlynn Aug 7, 2017

k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 7, 2017

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 7, 2017

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 7, 2017

k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2017

k8s-github-robot added this to the v1.7 milestone Aug 9, 2017

k8s-github-robot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 9, 2017

wojtek-t removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 9, 2017

fejta added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 10, 2017

nbutton23 closed this Aug 12, 2017

wojtek-t reopened this Aug 12, 2017

wojtek-t removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 12, 2017

k8s-github-robot merged commit 87e6b3b into kubernetes:release-1.7 Aug 12, 2017

Automated cherry pick of #49805 #50260

Automated cherry pick of #49805 #50260

Uh oh!

Conversation

nbutton23 commented Aug 7, 2017

Uh oh!

k8s-ci-robot commented Aug 7, 2017

Uh oh!

nbutton23 commented Aug 7, 2017

Uh oh!

zmerlynn commented Aug 7, 2017

Uh oh!

k8s-github-robot commented Aug 7, 2017

Uh oh!

fejta-bot commented Aug 9, 2017

Uh oh!

k8s-ci-robot commented Aug 9, 2017

Uh oh!

fejta-bot commented Aug 9, 2017

Uh oh!

k8s-ci-robot commented Aug 9, 2017

Uh oh!

fejta-bot commented Aug 9, 2017

Uh oh!

k8s-ci-robot commented Aug 9, 2017

Uh oh!

fejta-bot commented Aug 9, 2017

Uh oh!

k8s-ci-robot commented Aug 9, 2017

Uh oh!

fejta-bot commented Aug 9, 2017

Uh oh!

k8s-ci-robot commented Aug 9, 2017

Uh oh!

fejta-bot commented Aug 10, 2017

Uh oh!

k8s-ci-robot commented Aug 10, 2017

Uh oh!

fejta-bot commented Aug 10, 2017

Uh oh!

k8s-ci-robot commented Aug 10, 2017

Uh oh!

fejta-bot commented Aug 10, 2017

Uh oh!

k8s-ci-robot commented Aug 10, 2017

Uh oh!

fejta-bot commented Aug 10, 2017

Uh oh!

k8s-ci-robot commented Aug 10, 2017

Uh oh!

nbutton23 commented Aug 10, 2017

Uh oh!

wojtek-t commented Aug 11, 2017

Uh oh!

nbutton23 commented Aug 11, 2017

Uh oh!

k8s-ci-robot commented Aug 11, 2017

Uh oh!

nbutton23 commented Aug 12, 2017

Uh oh!

wojtek-t commented Aug 12, 2017

Uh oh!

wojtek-t commented Aug 12, 2017

Uh oh!

k8s-github-robot commented Aug 12, 2017

Uh oh!

k8s-github-robot commented Aug 12, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants