Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We never want to modify the globally defined SG for ELBs #49805

Merged
merged 1 commit into from
Aug 5, 2017
Merged

We never want to modify the globally defined SG for ELBs #49805

merged 1 commit into from
Aug 5, 2017

Conversation

nbutton23
Copy link
Contributor

@nbutton23 nbutton23 commented Jul 28, 2017 •
edited
Loading

What this PR does / why we need it:
Fixes a bug where creating or updating an ELB will modify a globally defined security group

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #50105

Special notes for your reviewer:

Release note:

fixes a bug around using the Global config ElbSecurityGroup where Kuberentes would modify the passed in Security Group.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 28, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @nbutton23. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 28, 2017
@nbutton23 nbutton23 mentioned this pull request Jul 28, 2017
Closed
@nbutton23
Copy link
Contributor Author

/assign @justinsb

@ericchiang
Copy link
Contributor

cc @lpabon

@jsafrane
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 31, 2017
@nbutton23
Copy link
Contributor Author

/retest

@justinsb
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: justinsb, nbutton23

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@nbutton23
Copy link
Contributor Author

/retest

@nbutton23
Copy link
Contributor Author

Looks like there is an known issue with the pull-kubernetes-bazel test #49844

@nbutton23
Copy link
Contributor Author

/retest

@waldman
Copy link

waldman commented Aug 2, 2017

Any Idea when this will be merged/released?

@nbutton23
Copy link
Contributor Author

@justinsb what do I need to do to get this into the merge Queue?

@nbutton23
Copy link
Contributor Author

/retest

@nbutton23 nbutton23 mentioned this pull request Aug 5, 2017
Closed
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2017
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot
Copy link
Contributor

@nbutton23: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-etcd3 7119a45 link /test pull-kubernetes-e2e-gce-etcd3

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 49805, 50052)

@k8s-github-robot k8s-github-robot merged commit 207a95a into kubernetes:master Aug 5, 2017
@wojtek-t wojtek-t added this to the v1.7 milestone Aug 7, 2017
@nbutton23 nbutton23 mentioned this pull request Aug 7, 2017
Merged
@nbutton23 nbutton23 deleted the nbutton-fix-elb-sg-bug branch August 7, 2017 18:02
@wojtek-t wojtek-t mentioned this pull request Aug 8, 2017
Closed
@wojtek-t wojtek-t added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 8, 2017
k8s-github-robot pushed a commit that referenced this pull request Aug 12, 2017
Merge pull request #50260 from nbutton23/automated-cherry-pick-of-#49…
87e6b3b 
…805-upstream-release-1.7

Automatic merge from submit-queue

Automated cherry pick of #49805

Cherry pick of #49805 on release-1.7.

#49805: We never want to modify the globally defined SG
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.7" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gnufied gnufied

@justinsb justinsb

@jsafrane jsafrane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

When using elbSecurityGroup cloudConfig with AWS, the sg's rules flap