Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not spin forever if kubectl drain races with other removal #49444

Merged
merged 1 commit into from
Jul 24, 2017
Merged

Do not spin forever if kubectl drain races with other removal #49444

merged 1 commit into from
Jul 24, 2017

Conversation

eparis
Copy link
Contributor

@eparis eparis commented Jul 22, 2017 •
edited by liggitt
Loading

In #47450 we stopped
returning an error if a pod disappeared before we could remove it.
Instead we just continue to spin forever. Return "success" if a pod
disappeared before we actually removed it.

https://bugzilla.redhat.com/1473777
bug 1473777

`kubectl drain` no longer spins trying to delete pods that do not exist

@eparis
Do not spin forever if kubectl drain races with other removal
7c531ec 
In kubernetes#47450 we stopped
returning an error if a pod disappeared before we could remove it.
Instead we just continue to spin forever. Return "success" if a pod
disappeared before we actually removed it.

https://bugzilla.redhat.com/1473777
bug 1473777
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 22, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Jul 22, 2017
@eparis
Copy link
Contributor Author

eparis commented Jul 22, 2017

@Kargakis @derekwaynecarr I think is a regression added in #47450

@0xmichalis
Copy link
Contributor

/lgtm

Needs to be backported to 1.7

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 22, 2017
This was referenced Jul 22, 2017
Closed
Merged
@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@eparis eparis added this to the v1.7 milestone Jul 22, 2017
@eparis
Copy link
Contributor Author

eparis commented Jul 22, 2017

/approve no-issue

@eparis
Copy link
Contributor Author

eparis commented Jul 23, 2017

/retest

@rootfs rootfs mentioned this pull request Jul 24, 2017
Merged
@liggitt
Copy link
Member

liggitt commented Jul 24, 2017

/lgtm

@liggitt liggitt added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jul 24, 2017
@liggitt
Copy link
Member

liggitt commented Jul 24, 2017

/approve no-issue

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eparis, kargakis, liggitt

Associated issue requirement bypassed by: liggitt

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2017
@0xmichalis
Copy link
Contributor

/retest

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 49444, 47864, 48584, 49395, 49118)

@k8s-github-robot k8s-github-robot merged commit 9891f66 into kubernetes:master Jul 24, 2017
@wojtek-t wojtek-t added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 25, 2017
k8s-github-robot pushed a commit that referenced this pull request Jul 25, 2017
Merge pull request #49447 from eparis/automated-cherry-pick-of-#49444…
383e554 
…-upstream-release-1.7

Automatic merge from submit-queue

Automated cherry pick of #49444 upstream release 1.7

Cherry pick of #49444 on release-1.7.

#49444: Do not spin forever if kubectl drain races with other removal
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.7" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fabianofranz fabianofranz

@sttts sttts

@liggitt liggitt

@0xmichalis 0xmichalis

@derekwaynecarr derekwaynecarr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.
10 participants
@eparis @0xmichalis @k8s-cherrypick-bot @liggitt @k8s-github-robot @fabianofranz @sttts @derekwaynecarr @wojtek-t @k8s-ci-robot