Skip to content

Automated cherry pick of #47602 upstream release 1.7 #49026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-github-robot merged 1 commit into from
Jul 25, 2017
Merged

Automated cherry pick of #47602 upstream release 1.7 #49026

k8s-github-robot merged 1 commit into from
Jul 25, 2017

Conversation

@rootfs
Copy link
Contributor

@rootfs rootfs commented Jul 17, 2017 •
edited by wojtek-t
Loading

Cherry pick of #47602 on release-1.7.

#47602 : rebase gophercloud to support HTTP status 300 in pagination, so listingng Cinder v1/v2 API versions won't break

@rootfs
rebase gophercloud to support HTTP status 300 in pagination, so listi…
5bf0efd 
…ng Cinder v1/v2 API versions won't break

Signed-off-by: Huamin Chen <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 17, 2017
@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Jul 17, 2017
@rootfs rootfs mentioned this pull request Jul 17, 2017
Merged
@rootfs
Copy link
Contributor Author

rootfs commented Jul 17, 2017

@idvoretskyi @dchen1107 can you approve? thanks!

@dims
Copy link
Member

dims commented Jul 17, 2017

This is great to have. I don't have karma to add cherrypick-approved label. +1 from me for backporting this.

@caesarxuchao
Copy link
Contributor

caesarxuchao commented Jul 17, 2017

cc @wojtek-t who's the patch branch manager.

Also please follow the cherrypick process (https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md#propose-a-cherry-pick), which requires labels to be added to master branch PR.

@saad-ali saad-ali added this to the v1.7 milestone Jul 19, 2017
@saad-ali
Copy link
Member

saad-ali commented Jul 19, 2017

/approve
/lgtm

@wojtek-t this is ok for cherry pick from storage SIG -- fixes a big regression in 1.7 with Openstack/Cinder

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2017
@wojtek-t wojtek-t changed the title rebase gophercloud to support HTTP status 300 in pagination, so listing Cinder v1/v2 API versions won't break Automated cherry pick of #47602 upstream release 1.7 Jul 24, 2017
@wojtek-t wojtek-t added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jul 24, 2017
@wojtek-t
Copy link
Member

wojtek-t commented Jul 24, 2017

/approve no-issue

@wojtek-t wojtek-t added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Jul 24, 2017
@k8s-github-robot
Copy link

k8s-github-robot commented Jul 24, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rootfs, saad-ali, wojtek-t

Associated issue: 47602

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2017
@wojtek-t
Copy link
Member

wojtek-t commented Jul 24, 2017

/test pull-kubernetes-e2e-kops-aws

@wojtek-t
Copy link
Member

wojtek-t commented Jul 24, 2017

/test pull-kubernetes-e2e-gce-etcd3

3 similar comments
@wojtek-t
Copy link
Member

wojtek-t commented Jul 24, 2017

/test pull-kubernetes-e2e-gce-etcd3

@wojtek-t
Copy link
Member

wojtek-t commented Jul 24, 2017

/test pull-kubernetes-e2e-gce-etcd3

@wojtek-t
Copy link
Member

wojtek-t commented Jul 24, 2017

/test pull-kubernetes-e2e-gce-etcd3

@wojtek-t
Copy link
Member

wojtek-t commented Jul 24, 2017

/retest

1 similar comment
@wojtek-t
Copy link
Member

wojtek-t commented Jul 25, 2017

/retest

@wojtek-t
Copy link
Member

wojtek-t commented Jul 25, 2017

/test pull-kubernetes-federation-e2e-gce

1 similar comment
@wojtek-t
Copy link
Member

wojtek-t commented Jul 25, 2017

/test pull-kubernetes-federation-e2e-gce

@k8s-github-robot
Copy link

k8s-github-robot commented Jul 25, 2017

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 1fdee96 into kubernetes:release-1.7 Jul 25, 2017
@liggitt liggitt mentioned this pull request Sep 14, 2017
Closed
52 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@caesarxuchao caesarxuchao

@dchen1107 dchen1107

@saad-ali saad-ali

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v1.7

Development

Successfully merging this pull request may close these issues.

8 participants

@rootfs @dims @caesarxuchao @saad-ali @wojtek-t @k8s-github-robot @dchen1107 @k8s-ci-robot