Bump up gce minNodesHealthCheckVersion due to known issues #49330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-github-robot
added
approved
MrHohn
force-pushed
the
bump-gce-minNodesHealthCheckVersion
branch
from
1a109a9
to
0db552d
Compare
k8s-github-robot
added
size/S
|
/release-note |
k8s-ci-robot
added
release-note
bowei
reviewed
Jul 20, 2017
| @@ -37,7 +37,7 @@ var ( | |||
| ) | |||
|
|
|||
| func init() { | |||
| if v, err := utilversion.ParseGeneric("1.7.0"); err != nil { | |||
| if v, err := utilversion.ParseGeneric("1.7.2"); err != nil { | |||
| panic(err) | |||
MrHohn
force-pushed
the
bump-gce-minNodesHealthCheckVersion
branch
from
0db552d
to
8557f7d
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MrHohn, nicksardo Associated issue: 49263 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
added 1.7 milestone for cherrypick |
|
/retest |
|
/test pull-kubernetes-federation-e2e-gce |
1 similar comment
|
/test pull-kubernetes-federation-e2e-gce |
|
Automatic merge from submit-queue |
|
Commit found in the "release-1.7" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: There are some known issues in previous 1.7 versions causing kube-proxy not correctly responding healthz traffic.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): From #49263.Special notes for your reviewer:
/assign @nicksardo @freehan
cc @bowei @thockin
Release note: