Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use custom port for node-problem-detector #49316

Merged
merged 1 commit into from
Jul 20, 2017
Merged

Use custom port for node-problem-detector #49316

merged 1 commit into from
Jul 20, 2017

Conversation

ajitak
Copy link
Contributor

@ajitak ajitak commented Jul 20, 2017 •
edited
Loading

It fixes #49263

Use port 20256 for node-problem-detector in standalone mode.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 20, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Jul 20, 2017
MrHohn
MrHohn approved these changes Jul 20, 2017
View reviewed changes
Copy link
Member

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix :)

@MrHohn
Copy link
Member

MrHohn commented Jul 20, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2017
@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Jul 20, 2017
@MrHohn
Copy link
Member

MrHohn commented Jul 20, 2017

cc @nicksardo @yujuhong @bowei

@MrHohn MrHohn mentioned this pull request Jul 20, 2017
Merged
@cjwagner
Copy link
Member

/retest

@k8s-github-robot k8s-github-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Jul 20, 2017
@ajitak
Copy link
Contributor Author

ajitak commented Jul 20, 2017

/assign @vishh

@ajitak
Copy link
Contributor Author

ajitak commented Jul 20, 2017

Test pull-kubernetes-federation-e2e-gce is flaky #49320

@MrHohn
Copy link
Member

MrHohn commented Jul 20, 2017

@madhusudancs @nikhiljindal The federation CI seems to be broken. It is failing on #49266 as well.
cc @krzyzacy

@krzyzacy
Copy link
Member

/test pull-kubernetes-federation-e2e-gce

1 similar comment
@MrHohn
Copy link
Member

MrHohn commented Jul 20, 2017

/test pull-kubernetes-federation-e2e-gce

@MrHohn
Copy link
Member

MrHohn commented Jul 20, 2017

@wojtek-t We need to get this in ASAP and cherrypick it into 1.7. Hopefully before 1.7.2 being cut.

@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@yujuhong yujuhong added this to the v1.7 milestone Jul 20, 2017
@yujuhong yujuhong added cherrypick-candidate and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Jul 20, 2017
@vishh
Copy link
Contributor

vishh commented Jul 20, 2017

/approve
/lgtm

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrHohn, ajitak, vishh

Associated issue: 49263

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2017
bowei
bowei reviewed Jul 20, 2017
View reviewed changes
cluster/gce/gci/configure-helper.sh
@@ -997,6 +997,8 @@ function start-node-problem-detector {
flags+=" --logtostderr"
flags+=" --system-log-monitors=${km_config},${dm_config}"
flags+=" --apiserver-override=https://${KUBERNETES_MASTER_NAME}?inClusterConfig=false&auth=/var/lib/node-problem-detector/kubeconfig"
local -r npd_port=${NODE_PROBLEM_DETECTOR_PORT:-20256}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this constant documented anywhere else?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. Where can I add it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not entirely sure, but I would like to surface the port allocation better to avoid other collisions in the future...

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 32bd2ab into kubernetes:master Jul 20, 2017
@ajitak ajitak deleted the npd-port branch July 20, 2017 23:36
@MrHohn MrHohn mentioned this pull request Jul 20, 2017
Merged
wojtek-t added a commit that referenced this pull request Jul 21, 2017
@wojtek-t
Merge pull request #49339 from MrHohn/automated-cherry-pick-of-#49316-#…
66bf0de 
…49330-upstream-release-1.7

Automated cherry pick of #49316 #49330
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.7" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei bowei left review comments

@MrHohn MrHohn MrHohn approved these changes

Assignees

@gmarek gmarek

@vishh vishh

@MrHohn MrHohn

@jszczepkowski jszczepkowski

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

Port collision between kube-proxy and node-problem-detector (standalone mode)