Skip to content

Conversation

@rootfs
Copy link
Contributor

@rootfs rootfs commented Jun 15, 2017

What this PR does / why we need it:
Since Cinder block v1/v2 support lands in 1.7, we have to ensure Cinder block api list won't fail due to gophercloud/gophercloud#384.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #47651

Special notes for your reviewer:

@anguslees @NickrenREN

Release note:

Fix Cinder to support http status 300 in pagination

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 15, 2017
@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Jun 15, 2017
@rootfs
Copy link
Contributor Author

rootfs commented Jun 15, 2017

/assign @NickrenREN @anguslees

@rootfs rootfs changed the title rebase gophercloud to support HTTP status 300 in pagination, so listing ng Cinder v1/v2 API versions won't break rebase gophercloud to support HTTP status 300 in pagination, so listingng Cinder v1/v2 API versions won't break Jun 15, 2017
@rootfs
Copy link
Contributor Author

rootfs commented Jun 15, 2017

@eparis @childsb

@dims
Copy link
Member

dims commented Jun 15, 2017

+1 LGTM

@eparis
Copy link
Contributor

eparis commented Jun 15, 2017

/approve
/sig sig-openstack

…ng Cinder v1/v2 API versions won't break

Signed-off-by: Huamin Chen <[email protected]>
@rootfs rootfs force-pushed the gophercloud-383 branch from 6678801 to ca65a6d Compare June 15, 2017 20:23
@rootfs
Copy link
Contributor Author

rootfs commented Jun 15, 2017

@k8s-bot pull-kubernetes-verify test this

@rootfs
Copy link
Contributor Author

rootfs commented Jun 15, 2017

@brendandburns can you approve? thanks

@brendandburns
Copy link
Contributor

@k8s-bot pull-kubernetes-federation-e2e-gce test this

@brendandburns
Copy link
Contributor

/approve

@brendandburns
Copy link
Contributor

@rootfs we need an issue to approve. given code freeze.

@NickrenREN
Copy link
Contributor

/cc @k8s-sig-openstack-bugs
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: NickrenREN, brendandburns, eparis, rootfs

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2017
@rootfs
Copy link
Contributor Author

rootfs commented Jun 16, 2017

@brendandburns Thanks, I opened issue #47651

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 46151, 47602, 47507, 46203, 47471)

@k8s-github-robot k8s-github-robot merged commit f5a5c50 into kubernetes:master Jun 23, 2017
@delfer
Copy link

delfer commented Jul 11, 2017

All 1.6.x and 1.7.x releases broken for now (can not work with cinder).
When this PR will be released?

@stuart-warren
Copy link
Contributor

This is really affecting us too on 1.7

Any chance in backporting?

/label cherrypick-candidate :)

@rootfs
Copy link
Contributor Author

rootfs commented Jul 17, 2017

@delfer @stuart-warren what error message did you see when you hit this issue?

@delfer
Copy link

delfer commented Jul 17, 2017

@rootfs When kubernetes asks openstack for cinder endpoints it got http error 300 - multiple choices. Means var variants: http://cinder_api/v1, http://cinder_api/v2, http://cinder_api/v3
And only error 300 in logs.

@rootfs
Copy link
Contributor Author

rootfs commented Jul 17, 2017

@delfer @stuart-warren cherry-pick PR opened.

@idvoretskyi can you approve 1.7 cherry pick PR #49026? Thanks

@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@wojtek-t wojtek-t added this to the v1.7 milestone Jul 20, 2017
@wojtek-t wojtek-t added release-note Denotes a PR that will be considered when it comes time to generate release notes. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jul 24, 2017
k8s-github-robot pushed a commit that referenced this pull request Jul 25, 2017
…-upstream-release-1.7

Automatic merge from submit-queue

Automated cherry pick of #47602 upstream release 1.7

Cherry pick of #47602 on release-1.7.

#47602 : rebase gophercloud to support HTTP status 300 in pagination, so listingng Cinder v1/v2 API versions won't break
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.7" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@jamiehannaford
Copy link
Contributor

Will this make it into 1.7.3? I didn't see it in 1.7.2 release or changelog

@delfer
Copy link

delfer commented Jul 26, 2017

Can confirm problem on 1.7.2

Events:
FirstSeen LastSeen Count From SubObjectPath Type Reason Message


32s 32s 1 default-scheduler Normal Scheduled Successfully assigned app-2122882019-hxk23 to test-k8s-node-nf-2
32s 32s 1 kubelet, test-k8s-node-nf-2 Normal SuccessfulMountVolume MountVolume.SetUp succeeded for volume "default-token-fcmxr"
31s 13s 6 attachdetach Warning FailedMount AttachVolume.Attach failed for volume "pv" : Expected HTTP response code [200 204] when accessing [GET http://192.168.72.51:8776/], but got 300 instead
{"versions": [{"status": "DEPRECATED", "updated": "2016-05-02T20:25:19Z", "links": [{"href": "http://docs.openstack.org/", "type": "text/html", "rel": "describedby"}, {"href": "http://192.168.72.51:8776/v1/", "rel": "self"}], "min_version": "", "version": "", "media-types": [{"base": "application/json", "type": "application/vnd.openstack.volume+json;version=1"}], "id": "v1.0"}, {"status": "SUPPORTED", "updated": "2014-06-28T12:20:21Z", "links": [{"href": "http://docs.openstack.org/", "type": "text/html", "rel": "describedby"}, {"href": "http://192.168.72.51:8776/v2/", "rel": "self"}], "min_version": "", "version": "", "media-types": [{"base": "application/json", "type": "application/vnd.openstack.volume+json;version=1"}], "id": "v2.0"}, {"status": "CURRENT", "updated": "2016-02-08T12:20:21Z", "links": [{"href": "http://docs.openstack.org/", "type": "text/html", "rel": "describedby"}, {"href": "http://192.168.72.51:8776/v3/", "rel": "self"}], "min_version": "3.0", "version": "3.27", "media-types": [{"base": "application/json", "type": "application/vnd.openstack.volume+json;version=1"}], "id": "v3.0"}]}

Please, cherrypick to 1.7.1 1.7.2 1.7.3

@jamiehannaford
Copy link
Contributor

/cc @wojtek-t

@k8s-ci-robot k8s-ci-robot requested a review from wojtek-t July 26, 2017 18:13
@rootfs
Copy link
Contributor Author

rootfs commented Jul 26, 2017

@jamiehannaford @delfer 1.7 cherrypick landed in release-1.7 branch a day ago. It should be in next 1.7 release.

@arykalin
Copy link

Got this on 1.7.2

@andrey01
Copy link

andrey01 commented Jul 27, 2017

yep, same here.. as a temporary workaround one can add the following chunk to your cloud provider conf file, in case if you use Cinder v2:

[BlockStorage]
bs-version=v2

@stuart-warren
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cinder API list received unsupported HTTP status 300 code