Skip to content

Automated cherry pick of #48849 #48856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gmarek wants to merge 1 commit into from
Closed

Automated cherry pick of #48849 #48856

gmarek wants to merge 1 commit into from

Conversation

@gmarek
Copy link
Contributor

@gmarek gmarek commented Jul 13, 2017

Cherry pick of #48849 on release-1.7.

#48849: Remove address getter from CreateAddress(Region and Global)

@k8s-github-robot
Copy link

k8s-github-robot commented Jul 13, 2017

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gmarek
We suggest the following additional approver: bowei

Assign the PR to them by writing /assign @bowei in a comment when ready.

Associated issue: 48849

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added this to the v1.7 milestone Jul 13, 2017
@k8s-github-robot k8s-github-robot added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 13, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 13, 2017
@gmarek gmarek closed this Jul 13, 2017
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 13, 2017 •
edited
Loading

@gmarek: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-federation-e2e-gce ba7b6bd link /test pull-kubernetes-federation-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@vmarmol vmarmol

@derekwaynecarr derekwaynecarr

Labels

cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v1.7

Development

Successfully merging this pull request may close these issues.

5 participants

@gmarek @k8s-github-robot @k8s-ci-robot @vmarmol @derekwaynecarr