Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCE: Fix panic when service loadbalancer has static IP address #48849

Merged
merged 1 commit into from
Jul 13, 2017
Merged

GCE: Fix panic when service loadbalancer has static IP address #48849

merged 1 commit into from
Jul 13, 2017

Conversation

nicksardo
Copy link
Contributor

@nicksardo nicksardo commented Jul 13, 2017 •
edited
Loading

Fixes #48848

Fix service controller crash loop when Service with GCP LoadBalancer uses static IP (#48848, @nicksardo)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 13, 2017
@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-label-needed labels Jul 13, 2017
@nicksardo
Copy link
Contributor Author

/assign @bowei
/unassign @vmarmol @jsafrane

@k8s-ci-robot k8s-ci-robot assigned bowei and unassigned vmarmol and jsafrane Jul 13, 2017
@k8s-github-robot k8s-github-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Jul 13, 2017
@bowei
Copy link
Member

bowei commented Jul 13, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, nicksardo

Associated issue: 48848

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2017
@bowei
Copy link
Member

bowei commented Jul 13, 2017

Does this have impact on Ingress or no?

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 48555, 48849)

@k8s-github-robot k8s-github-robot merged commit 74f1943 into kubernetes:master Jul 13, 2017
@wojtek-t wojtek-t added this to the v1.7 milestone Jul 13, 2017
@wojtek-t wojtek-t added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cherrypick-candidate labels Jul 13, 2017
@wojtek-t
Copy link
Member

Cherypicking it to 1.7 branch now.

@wojtek-t wojtek-t mentioned this pull request Jul 13, 2017
Merged
@gmarek gmarek mentioned this pull request Jul 13, 2017
Closed
@gmarek
Copy link
Contributor

gmarek commented Jul 13, 2017

@wojtek-t - OK, you were first:)

k8s-github-robot pushed a commit that referenced this pull request Jul 14, 2017
Merge pull request #48855 from wojtek-t/automated-cherry-pick-of-#488…
f550b1b 
…49-upstream-release-1.7

Automatic merge from submit-queue

Automated cherry pick of #48849 upstream release 1.7

Cherry pick of #48524 and #48849 on release-1.7.

#48849 : GCE: Fix panic when service loadbalancer has static IP address
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.7" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@nicksardo nicksardo deleted the gce-panic-fix branch January 12, 2018 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bowei bowei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.
10 participants
@nicksardo @bowei @k8s-github-robot @wojtek-t @gmarek @k8s-cherrypick-bot @vmarmol @jsafrane @satnam6502 @k8s-ci-robot