Remove VCenterPort from vsphere cloud provider. #42024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The url which is used for communicating with govmomi should not include port number. A port number other than 443 will result in 404 error. VCenterPort stays in VSphereConfig structure for backward compatibility.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-github-robot
added
the
approved
k8s-github-robot
added
size/S
|
This change is |
|
@k8s-bot cvm gke e2e test this |
|
/approve |
jingxu97
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED The following people have approved this PR: jingxu97, luomiao Needs approval from an approver in each of these OWNERS Files: We suggest the following people: |
k8s-github-robot
added
the
do-not-merge
|
@k8s-bot gci gce e2e test this |
jingxu97
removed
do-not-merge
k8s-github-robot
added
release-note-label-needed
do-not-merge
jingxu97
removed
do-not-merge
k8s-github-robot
added
release-note-label-needed
do-not-merge
jingxu97
removed
do-not-merge
k8s-github-robot
added
release-note-label-needed
do-not-merge
jingxu97
added
the
release-note-none
jingxu97
removed
do-not-merge
|
Automatic merge from submit-queue |
This was referenced Jul 27, 2017
k8s-github-robot
pushed a commit
that referenced
this pull request
Jul 28, 2017
Automatic merge from submit-queue (batch tested with PRs 49665, 49689, 49495, 49146, 48934) Reverting deprecation of vCenter port in vSphere Cloud Provider **What this PR does / why we need it**: This PR reverts back the deprecation of vCenter port made with PR: #42024 We observed an issue when kubernetes cluster is deployed on the vCenter with non-default Port. When VC is configured with non default port govmomi requests were going to default port 443. This is not valid, as confirmed in vmware/govmomi#802 **Which issue this PR fixes** fixes # vmware-archive#220 **Special notes for your reviewer**: Verified with deploying Kubernetes Cluster on the vCenter with port (7443). Used following vsphere.conf file on master and worker nodes ``` # cat vsphere.conf [Global] user = "[email protected]" password = "Admin!23" server = "10.192.87.209" port = "7443" insecure-flag = "1" datacenter = "Datacenter" datastore = "storage1" working-dir = "kubernetes" [Disk] scsicontrollertype = pvscsi ``` Created Storage Class, PV, PVC and Pod. Verified Attach, Detach, Create and Delete Volume Operations are working as expected. Also verified with completely removing port from vsphere.conf file. default 443 is used in this case. ``` # cat vsphere.conf [Global] user = "[email protected]" password = "Admin!23" server = "10.192.66.216" insecure-flag = "1" datacenter = "Datacenter" datastore = "storage1" working-dir = "kubernetes" [Disk] scsicontrollertype = pvscsi ``` **Release note**: ```release-note NONE ``` @luomiao @BaluDontu @tusharnt @rohitjogvmw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Address a bug inside vsphere cloud provider when a port number other than 443 is specified inside the config file.
The url which is used for communicating with govmomi should not include port number.
A port number other than 443 will result in 404 error.
VCenterPort stays in VSphereConfig structure for backward compatibility.
Which issue this PR fixes : fixes kubernetes-retired/kubernetes-anywhere#338