Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for new aws partitions in credential provider #981

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

kmala
Copy link
Member

@kmala kmala commented Jun 27, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Allow credential provider to recognize new aws partitions.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 27, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jun 27, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 27, 2024
@dims
Copy link
Member

dims commented Jun 27, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2024
@kmala
Copy link
Member Author

kmala commented Jun 27, 2024

/test pull-cloud-provider-aws-e2e-kubetest2
/test pull-cloud-provider-aws-e2e-kubetest2-quick

@cartermckinnon
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2024
@k8s-ci-robot k8s-ci-robot merged commit 9c64eec into kubernetes:master Jun 27, 2024
12 of 13 checks passed
k8s-ci-robot added a commit that referenced this pull request Jun 27, 2024
…ream-release-1.27

Automated cherry pick of #981: add support for new aws partitions in credential provider
k8s-ci-robot added a commit that referenced this pull request Jun 27, 2024
…ream-release-1.28

Automated cherry pick of #981: add support for new aws partitions in credential provider
k8s-ci-robot added a commit that referenced this pull request Jun 27, 2024
…ream-release-1.29

Automated cherry pick of #981: add support for new aws partitions in credential provider
k8s-ci-robot added a commit that referenced this pull request Jun 27, 2024
…ream-release-1.30

Automated cherry pick of #981: add support for new aws partitions in credential provider
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants