Skip to content

chore(sdk): depend on protobuf 4 in kfp and kfp-kubernetes #10307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
google-oss-prow merged 1 commit into from
Jan 11, 2024
Merged

chore(sdk): depend on protobuf 4 in kfp and kfp-kubernetes #10307

google-oss-prow merged 1 commit into from
Jan 11, 2024

Conversation

@connor-mccarthy
Copy link
Member

@connor-mccarthy connor-mccarthy commented Dec 12, 2023 •
edited
Loading

Description of your changes:
#protobuf4

This PR makes the kfp and kfp-kubernetes changes together, since that plays most nicely with our simple test triggering logic.

Checklist:

@google-oss-prow
Copy link

google-oss-prow bot commented Dec 12, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@bdattoma bdattoma mentioned this pull request Dec 21, 2023
Merged
@connor-mccarthy
Copy link
Member Author

connor-mccarthy commented Jan 10, 2024

/test all

@google-oss-prow google-oss-prow bot added size/S and removed size/XS labels Jan 10, 2024
@connor-mccarthy
Copy link
Member Author

connor-mccarthy commented Jan 10, 2024

/retest

@connor-mccarthy connor-mccarthy changed the title chore(sdk): depend on protobuf 4 in kfp chore(sdk): depend on protobuf 4 in kfp and kfp-kubernetes Jan 11, 2024
@connor-mccarthy connor-mccarthy marked this pull request as ready for review January 11, 2024 18:57
@google-oss-prow google-oss-prow bot requested a review from gkcalat January 11, 2024 18:57
@google-oss-prow
Copy link

google-oss-prow bot commented Jan 11, 2024

@connor-mccarthy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kfp-kubernetes-execution-tests 8b90df6 link false /test kfp-kubernetes-execution-tests
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

chensun
chensun approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Jan 11, 2024
@google-oss-prow
Copy link

google-oss-prow bot commented Jan 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit db6fe05 into kubeflow:master Jan 11, 2024
stijntratsaertit pushed a commit to stijntratsaertit/kfp that referenced this pull request Feb 16, 2024
@connor-mccarthy @stijntratsaertit
chore(sdk): depend on protobuf 4 in kfp and kfp-kubernetes (kubef…
978a96e 
…low#10307)
petethegreat pushed a commit to petethegreat/pipelines that referenced this pull request Mar 27, 2024
@connor-mccarthy @petethegreat
chore(sdk): depend on protobuf 4 in kfp and kfp-kubernetes (kubef…
0e8a2d4 
…low#10307)
petethegreat pushed a commit to petethegreat/pipelines that referenced this pull request Mar 29, 2024
@connor-mccarthy @petethegreat
chore(sdk): depend on protobuf 4 in kfp and kfp-kubernetes (kubef…
3edcc00 
…low#10307)
@mynewestgitaccount mynewestgitaccount mentioned this pull request Nov 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chensun chensun chensun approved these changes

@zijianjoy zijianjoy Awaiting requested review from zijianjoy

@gkcalat gkcalat Awaiting requested review from gkcalat

Assignees

@chensun chensun

Labels

approved lgtm size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@connor-mccarthy @chensun