Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdk] Support for Protobuf 5 #11167

Open
lsmurray opened this issue Sep 4, 2024 · 7 comments
Open

[sdk] Support for Protobuf 5 #11167

lsmurray opened this issue Sep 4, 2024 · 7 comments

Comments

@lsmurray
Copy link

lsmurray commented Sep 4, 2024

Environment

The latest kfp version pins protobuf < 5.0:

protobuf>=4.21.1,<5

Other packages such as grpcio are starting to require protobuf 5. What would it take for KFP to support protobuf 5?


Impacted by this bug? Give it a 👍.

Copy link

github-actions bot commented Nov 4, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Nov 4, 2024
@lsmurray
Copy link
Author

lsmurray commented Nov 5, 2024

not stale!

@HumairAK
Copy link
Collaborator

HumairAK commented Nov 5, 2024

definitely not! 😄

/remove-lifecycle stale
/lifecycle frozen

@google-oss-prow google-oss-prow bot added lifecycle/frozen and removed lifecycle/stale The issue / pull request is stale, any activities remove this label. labels Nov 5, 2024
@HumairAK
Copy link
Collaborator

HumairAK commented Nov 5, 2024

cc @gregsheremeta fyi ^

@chensun
Copy link
Member

chensun commented Nov 19, 2024

@HumairAK, @gregsheremeta, if I understand correctly, you plan to work on this? If so, any timeline? Thanks!

@gregsheremeta
Copy link
Contributor

I'd love to work on it. Let us get back to you with a timeline.

@HumairAK HumairAK added this to the KFP 2.5.0 milestone Nov 20, 2024
@mynewestgitaccount
Copy link

mynewestgitaccount commented Nov 24, 2024

When this is worked on, it would be great if it could be done in a way that allows simultaneous support for Protobuf 4 and Protobuf 5. That way, users upgrading their kfp version won't be forced to track down and upgrade all packages depending on Protobuf 4 at the same time.

When support for Protobuf 4 was added to kfp in #10305 and #10307, support for Protobuf 3 was dropped in the same commits/releases. That was not ideal for users.


All of the GCP SDK packages support Protobuf 3, Protobuf 4, and Protobuf 5 together (example: google-cloud-pubsub). Hopefully something similar can be done for kfp for Protobuf 4/5.

The GCP SDK packages seem to achieve their simultaneous support by using the proto-plus package as a compatibility layer. It's possible that a similar approach would work for kfp. And even if that wouldn't work, that proto-plus package itself supports multiple versions of Protobuf, so perhaps what is done there would work for kfp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants