-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sdk] Support for Protobuf 5 #11167
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
not stale! |
definitely not! 😄 /remove-lifecycle stale |
cc @gregsheremeta fyi ^ |
@HumairAK, @gregsheremeta, if I understand correctly, you plan to work on this? If so, any timeline? Thanks! |
I'd love to work on it. Let us get back to you with a timeline. |
When this is worked on, it would be great if it could be done in a way that allows simultaneous support for Protobuf 4 and Protobuf 5. That way, users upgrading their kfp version won't be forced to track down and upgrade all packages depending on Protobuf 4 at the same time. When support for Protobuf 4 was added to kfp in #10305 and #10307, support for Protobuf 3 was dropped in the same commits/releases. That was not ideal for users. All of the GCP SDK packages support Protobuf 3, Protobuf 4, and Protobuf 5 together (example: google-cloud-pubsub). Hopefully something similar can be done for kfp for Protobuf 4/5. The GCP SDK packages seem to achieve their simultaneous support by using the proto-plus package as a compatibility layer. It's possible that a similar approach would work for kfp. And even if that wouldn't work, that proto-plus package itself supports multiple versions of Protobuf, so perhaps what is done there would work for kfp. |
Environment
The latest
kfp
version pinsprotobuf < 5.0
:pipelines/sdk/python/requirements.in
Line 21 in 2c91fb7
Other packages such as grpcio are starting to require protobuf 5. What would it take for KFP to support protobuf 5?
Impacted by this bug? Give it a 👍.
The text was updated successfully, but these errors were encountered: