Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: RFC6265 compliant default cookie name #197

Merged
merged 1 commit into from
Apr 28, 2020
Merged

fix: RFC6265 compliant default cookie name #197

merged 1 commit into from
Apr 28, 2020

Conversation

zacanger
Copy link
Contributor

Closes #28

@zacanger zacanger changed the title fix: RFC6265 default cookie name fix: RFC6265 compliant default cookie name Apr 23, 2020
@coveralls
Copy link

coveralls commented Apr 23, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling dd52632 on zacanger:fix/default-cookie-name into 23f7f52 on koajs:master.

@zacanger zacanger mentioned this pull request Apr 23, 2020
Closed
@jonathanong jonathanong self-assigned this Apr 24, 2020
@dead-horse
Copy link
Member

we can't merge this right now because It can break compatibility, maybe you can add a note in README ?

@zacanger
Copy link
Contributor Author

@dead-horse good point. Should that go in History.md instead as a major version note?

@jonathanong
Copy link
Member

@zacanger yep.

we can do a major bump - we shouldn't be afraid to do those

@jonathanong jonathanong assigned dead-horse and fengmk2 and unassigned jonathanong Apr 24, 2020
@zacanger
Copy link
Contributor Author

zacanger commented Apr 24, 2020 •
edited
Loading

@jonathanong sounds good, changelog updated!

@dead-horse dead-horse merged commit 7fca3de into koajs:master Apr 28, 2020
@zacanger zacanger deleted the fix/default-cookie-name branch April 28, 2020 16:17
@dead-horse
Copy link
Member

6.0.0 released

@zacanger
Copy link
Contributor Author

Sorry about the package-lock, I forgot Koa repos don't use that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominicegginton dominicegginton dominicegginton approved these changes

@dead-horse dead-horse dead-horse approved these changes

Assignees

@fengmk2 fengmk2

@dead-horse dead-horse

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default cookie name doesn't satisfy RFC6265
6 participants
@zacanger @coveralls @dead-horse @jonathanong @dominicegginton @fengmk2