Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default cookie name doesn't satisfy RFC6265 #28

Closed
guersam opened this issue Jul 2, 2014 · 5 comments · Fixed by #197
Closed

Default cookie name doesn't satisfy RFC6265 #28

guersam opened this issue Jul 2, 2014 · 5 comments · Fixed by #197

Comments

@guersam
Copy link

guersam commented Jul 2, 2014

The default cookie name koa:sess contains :, which is not a valid token character in accordance with RFC6265 and RFC2616. Although most web browsers and servers allow this, it causes problems in some more strict environment such as spray.

Would you consider remaining it? If so, should we take backward compatibility into account?
@guersam guersam mentioned this issue Jul 2, 2014
Closed
@jonathanong
Copy link
Member

sure

@jonathanong
Copy link
Member

i'll add this in the next version when the sessions can/will be encrypted

@tj
Copy link
Member

tj commented Jul 3, 2014

wtf, if it's quoted it shouldn't matter, weird spec is weird

@Oursin
Copy link

Oursin commented Feb 25, 2020

Hi, any updates on this ?

I'm building a server that communicates with a Dart application, with session handling via cookies. Dart validates the cookie names against the RFC, and thus throws an error while parsing a koa:sess cookie.

For now I've simply changed the name manually, but I think it would be great to have a default cookie name that doesn't break the RFC.

@zacanger zacanger mentioned this issue Apr 23, 2020
Merged
@zacanger
Copy link
Contributor

@Oursin #197 fixes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: RFC6265 compliant default cookie name
5 participants
@tj @jonathanong @guersam @zacanger @Oursin