Add Live Process Integration Saved Views (DataDog#8634)

* add live process integration saved views for integrations with "process_signatures" * update validation to include process_overview page * update views to use name field vs integration_id when creating filter tag * remove ssh_check process integration saved view * use display name in integration saved view
kkourtchikov · Feb 23, 2021 · 0034894 · 0034894
1 parent 20c612c
commit 0034894
Show file tree

Hide file tree

Showing 89 changed files with 1,612 additions and 48 deletions.
diff --git a/activemq/assets/saved_views/activemq_processes.json b/activemq/assets/saved_views/activemq_processes.json
@@ -0,0 +1,33 @@
+{
+  "name": "ActiveMQ",
+  "type": "process",
+  "page": "process_overview",
+  "query": "Filter by: integration:activemq",
+  "options": {
+    "sort": {
+      "order": "DESC",
+      "key": "memory"
+    },
+    "graph_options": {},
+    "view_options": [
+      "normalizeCPU",
+      "showArguments"
+    ],
+    "filter": {
+      "text": "",
+      "groups": [],
+      "tags": [
+        "integration:activemq"
+      ]
+    },
+    "selected_top_graph": "scatterplot",
+    "enabled_columns": [
+      "cpu",
+      "host",
+      "mem",
+      "proc",
+      "start",
+      "user"
+    ]
+  }
+}
diff --git a/activemq/manifest.json b/activemq/manifest.json
@@ -39,6 +39,9 @@
     "logs": {
       "source": "activemq"
     },
-    "metrics_metadata": "metadata.csv"
+    "metrics_metadata": "metadata.csv",
+    "saved_views": {
+      "activemq_processes": "assets/saved_views/activemq_processes.json"
+    }
   }
 }
diff --git a/apache/assets/saved_views/apache_processes.json b/apache/assets/saved_views/apache_processes.json
@@ -0,0 +1,33 @@
+{
+  "name": "Apache",
+  "type": "process",
+  "page": "process_overview",
+  "query": "Filter by: integration:apache",
+  "options": {
+    "sort": {
+      "order": "DESC",
+      "key": "memory"
+    },
+    "graph_options": {},
+    "view_options": [
+      "normalizeCPU",
+      "showArguments"
+    ],
+    "filter": {
+      "text": "",
+      "groups": [],
+      "tags": [
+        "integration:apache"
+      ]
+    },
+    "selected_top_graph": "scatterplot",
+    "enabled_columns": [
+      "cpu",
+      "host",
+      "mem",
+      "proc",
+      "start",
+      "user"
+    ]
+  }
+}
diff --git a/apache/manifest.json b/apache/manifest.json
@@ -47,7 +47,8 @@
       "4xx_errors": "assets/saved_views/4xx_errors.json",
       "5xx_errors": "assets/saved_views/5xx_errors.json",
       "status_code_overview": "assets/saved_views/status_code_overview.json",
-      "bot_errors": "assets/saved_views/bot_errors.json"
+      "bot_errors": "assets/saved_views/bot_errors.json",
+      "apache_processes": "assets/saved_views/apache_processes.json"
     },
     "service_checks": "assets/service_checks.json",
     "logs": {

diff --git a/cassandra/assets/saved_views/cassandra_processes.json b/cassandra/assets/saved_views/cassandra_processes.json
@@ -0,0 +1,33 @@
+{
+  "name": "Cassandra",
+  "type": "process",
+  "page": "process_overview",
+  "query": "Filter by: integration:cassandra",
+  "options": {
+    "sort": {
+      "order": "DESC",
+      "key": "memory"
+    },
+    "graph_options": {},
+    "view_options": [
+      "normalizeCPU",
+      "showArguments"
+    ],
+    "filter": {
+      "text": "",
+      "groups": [],
+      "tags": [
+        "integration:cassandra"
+      ]
+    },
+    "selected_top_graph": "scatterplot",
+    "enabled_columns": [
+      "cpu",
+      "host",
+      "mem",
+      "proc",
+      "start",
+      "user"
+    ]
+  }
+}
diff --git a/cassandra/manifest.json b/cassandra/manifest.json
@@ -41,6 +41,9 @@
     "logs": {
       "source": "cassandra"
     },
-    "metrics_metadata": "metadata.csv"
+    "metrics_metadata": "metadata.csv",
+    "saved_views": {
+      "cassandra_processes": "assets/saved_views/cassandra_processes.json"
+    }
   }
 }
diff --git a/ceph/assets/saved_views/ceph_processes.json b/ceph/assets/saved_views/ceph_processes.json
@@ -0,0 +1,33 @@
+{
+  "name": "Ceph",
+  "type": "process",
+  "page": "process_overview",
+  "query": "Filter by: integration:ceph",
+  "options": {
+    "sort": {
+      "order": "DESC",
+      "key": "memory"
+    },
+    "graph_options": {},
+    "view_options": [
+      "normalizeCPU",
+      "showArguments"
+    ],
+    "filter": {
+      "text": "",
+      "groups": [],
+      "tags": [
+        "integration:ceph"
+      ]
+    },
+    "selected_top_graph": "scatterplot",
+    "enabled_columns": [
+      "cpu",
+      "host",
+      "mem",
+      "proc",
+      "start",
+      "user"
+    ]
+  }
+}
diff --git a/ceph/manifest.json b/ceph/manifest.json
@@ -39,6 +39,9 @@
     "logs": {
       "source": "ceph"
     },
-    "metrics_metadata": "metadata.csv"
+    "metrics_metadata": "metadata.csv",
+    "saved_views": {
+      "ceph_processes": "assets/saved_views/ceph_processes.json"
+    }
   }
 }
diff --git a/consul/assets/saved_views/consul_processes.json b/consul/assets/saved_views/consul_processes.json
@@ -0,0 +1,33 @@
+{
+  "name": "Consul",
+  "type": "process",
+  "page": "process_overview",
+  "query": "Filter by: integration:consul",
+  "options": {
+    "sort": {
+      "order": "DESC",
+      "key": "memory"
+    },
+    "graph_options": {},
+    "view_options": [
+      "normalizeCPU",
+      "showArguments"
+    ],
+    "filter": {
+      "text": "",
+      "groups": [],
+      "tags": [
+        "integration:consul"
+      ]
+    },
+    "selected_top_graph": "scatterplot",
+    "enabled_columns": [
+      "cpu",
+      "host",
+      "mem",
+      "proc",
+      "start",
+      "user"
+    ]
+  }
+}
diff --git a/consul/manifest.json b/consul/manifest.json
@@ -43,6 +43,9 @@
     "logs": {
       "source": "consul"
     },
-    "metrics_metadata": "metadata.csv"
+    "metrics_metadata": "metadata.csv",
+    "saved_views": {
+      "consul_processes": "assets/saved_views/consul_processes.json"
+    }
   }
 }
diff --git a/couch/assets/saved_views/couchdb_processes.json b/couch/assets/saved_views/couchdb_processes.json
@@ -0,0 +1,33 @@
+{
+  "name": "CouchDB",
+  "type": "process",
+  "page": "process_overview",
+  "query": "Filter by: integration:couch",
+  "options": {
+    "sort": {
+      "order": "DESC",
+      "key": "memory"
+    },
+    "graph_options": {},
+    "view_options": [
+      "normalizeCPU",
+      "showArguments"
+    ],
+    "filter": {
+      "text": "",
+      "groups": [],
+      "tags": [
+        "integration:couch"
+      ]
+    },
+    "selected_top_graph": "scatterplot",
+    "enabled_columns": [
+      "cpu",
+      "host",
+      "mem",
+      "proc",
+      "start",
+      "user"
+    ]
+  }
+}
diff --git a/couch/manifest.json b/couch/manifest.json
@@ -45,6 +45,9 @@
     "logs": {
       "source": "couchdb"
     },
-    "metrics_metadata": "metadata.csv"
+    "metrics_metadata": "metadata.csv",
+    "saved_views": {
+      "couchdb_processes": "assets/saved_views/couchdb_processes.json"
+    }
   }
 }
diff --git a/couchbase/assets/saved_views/couchbase_processes.json b/couchbase/assets/saved_views/couchbase_processes.json
@@ -0,0 +1,33 @@
+{
+  "name": "Couchbase",
+  "type": "process",
+  "page": "process_overview",
+  "query": "Filter by: integration:couchbase",
+  "options": {
+    "sort": {
+      "order": "DESC",
+      "key": "memory"
+    },
+    "graph_options": {},
+    "view_options": [
+      "normalizeCPU",
+      "showArguments"
+    ],
+    "filter": {
+      "text": "",
+      "groups": [],
+      "tags": [
+        "integration:couchbase"
+      ]
+    },
+    "selected_top_graph": "scatterplot",
+    "enabled_columns": [
+      "cpu",
+      "host",
+      "mem",
+      "proc",
+      "start",
+      "user"
+    ]
+  }
+}
diff --git a/couchbase/manifest.json b/couchbase/manifest.json
@@ -33,6 +33,9 @@
     "dashboards": {},
     "service_checks": "assets/service_checks.json",
     "logs": {},
-    "metrics_metadata": "metadata.csv"
+    "metrics_metadata": "metadata.csv",
+    "saved_views": {
+      "couchbase_processes": "assets/saved_views/couchbase_processes.json"
+    }
   }
 }
diff --git a/datadog_checks_dev/datadog_checks/dev/tooling/commands/validate/saved_views.py b/datadog_checks_dev/datadog_checks/dev/tooling/commands/validate/saved_views.py
@@ -14,9 +14,9 @@
 
 ALL_HEADERS = REQUIRED_HEADERS | OPTIONAL_HEADERS
 
-VALID_TYPES = {'logs', 'trace'}
+VALID_TYPES = {'logs', 'trace', 'process'}
 
-VALID_PAGES = {'analytics', 'insights', 'patterns', 'stream', 'traces'}
+VALID_PAGES = {'analytics', 'insights', 'patterns', 'stream', 'traces', 'process_overview'}
 
 NO_OPTIONS_PAGES = {'insights', 'patterns', 'traces'}
 
@@ -32,6 +32,8 @@
 
 ANALYTICS_OPTIONS = {"aggregations", "group_bys", "limit", "order", "step_ms", "widget"}
 
+PROCESS_OPTIONS = {"sort", "graph_options", "view_options", "filter", "selected_top_graph", "enabled_columns"}
+
 
 @click.command(context_settings=CONTEXT_SETTINGS, short_help='Validate saved view files')
 @click.argument('integration', autocompletion=complete_valid_checks, required=False)
@@ -115,6 +117,13 @@ def saved_views(integration):
                     f"for page `analytics`: {view_options_set}"
                 )
 
+            elif view_page == "process_overview" and not view_options_set.issubset(PROCESS_OPTIONS):
+                errors = True
+                echo_failure(
+                    f"{integration} saved view ({view['name']}) has an invalid options "
+                    f"for page `process_overview`: {view_options_set}"
+                )
+
             elif view_page in NO_OPTIONS_PAGES and view_options:
                 errors = True
                 echo_failure(

diff --git a/elastic/assets/saved_views/elasticsearch_processes.json b/elastic/assets/saved_views/elasticsearch_processes.json
@@ -0,0 +1,33 @@
+{
+  "name": "Elasticsearch",
+  "type": "process",
+  "page": "process_overview",
+  "query": "Filter by: integration:elastic",
+  "options": {
+    "sort": {
+      "order": "DESC",
+      "key": "memory"
+    },
+    "graph_options": {},
+    "view_options": [
+      "normalizeCPU",
+      "showArguments"
+    ],
+    "filter": {
+      "text": "",
+      "groups": [],
+      "tags": [
+        "integration:elastic"
+      ]
+    },
+    "selected_top_graph": "scatterplot",
+    "enabled_columns": [
+      "cpu",
+      "host",
+      "mem",
+      "proc",
+      "start",
+      "user"
+    ]
+  }
+}
diff --git a/elastic/manifest.json b/elastic/manifest.json
@@ -42,6 +42,9 @@
     "logs": {
       "source": "elasticsearch"
     },
-    "metrics_metadata": "metadata.csv"
+    "metrics_metadata": "metadata.csv",
+    "saved_views": {
+      "elasticsearch_processes": "assets/saved_views/elasticsearch_processes.json"
+    }
   }
 }