Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Live Process Integration Saved Views #8634

Merged
merged 7 commits into from
Feb 23, 2021
Merged

Add Live Process Integration Saved Views #8634

merged 7 commits into from
Feb 23, 2021

Conversation

vatteh
Copy link
Contributor

@vatteh vatteh commented Feb 16, 2021 •
edited
Loading

What does this PR do?

Used a script to add saved views to any integration with the "process_integrations" field. These integrations will have the integration tag used to create saved views in the Live Processes page

@DataDog/processes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@vatteh vatteh marked this pull request as ready for review February 17, 2021 07:49
@vatteh vatteh requested review from a team as code owners February 17, 2021 07:49
kayayarai
kayayarai reviewed Feb 17, 2021
View reviewed changes
Copy link
Contributor

@kayayarai kayayarai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No docs/description text to review

FlorianVeaux
FlorianVeaux previously approved these changes Feb 22, 2021
View reviewed changes
Copy link
Member

@FlorianVeaux FlorianVeaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, saved views are correctly formatted, and I can see them in the staging environment.
Good to merge 👍

@FlorianVeaux FlorianVeaux merged commit 0034894 into master Feb 23, 2021
@FlorianVeaux FlorianVeaux deleted the victor.atteh/process_add_integration_saved_views branch February 23, 2021 14:55
github-actions bot pushed a commit that referenced this pull request Feb 23, 2021
@FlorianVeaux
Add Live Process Integration Saved Views (#8634)
0186f18 
* add live process integration saved views for integrations with "process_signatures"

* update validation to include process_overview page

* update views to use name field vs integration_id when creating filter tag

* remove ssh_check process integration saved view

* use display name in integration saved view 0034894
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kayayarai kayayarai kayayarai left review comments

@FlorianVeaux FlorianVeaux FlorianVeaux approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog dev/tooling documentation integration/activemq integration/apache integration/cassandra integration/ceph integration/consul integration/couch integration/couchbase integration/datadog_checks_dev integration/elastic integration/etcd integration/fluentd integration/gearmand integration/glusterfs integration/gunicorn integration/haproxy integration/kafka integration/kong integration/kyototycoon integration/lighttpd integration/marathon integration/marklogic integration/mcache integration/mesos_master integration/mongo integration/mysql integration/nagios integration/nginx integration/openstack integration/pgbouncer integration/php_fpm integration/postfix integration/postgres integration/powerdns_recursor integration/rabbitmq integration/redisdb integration/rethinkdb integration/riakcs integration/solr integration/ssh_check integration/supervisord integration/teamcity integration/tokumx integration/tomcat integration/varnish integration/voltdb integration/zk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vatteh @kayayarai @FlorianVeaux