Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BindAddress option #2477

Closed
grifball opened this issue Dec 1, 2016 · 2 comments · Fixed by karronoli/redpen#10
Closed

BindAddress option #2477

grifball opened this issue Dec 1, 2016 · 2 comments · Fixed by karronoli/redpen#10
Labels
help wanted type: feature

Comments

@grifball
Copy link
Contributor

grifball commented Dec 1, 2016 •
edited
Loading

I'm sorry if this option already exists and I just didn't notice it.
I'm using karma on a private project on a server with port 9876 open.
Rather than going through and closing that port in the firewall, it's easier just to bind to 127.0.0.1 instead of 0.0.0.0.
So I added support into karma for that, it's a simple change, I included a diff of the files.
I'm using karma version 1.3.0
diff new old.txt

Let me know what you guys think of having this option.
@maksimr
Copy link
Contributor

maksimr commented Dec 1, 2016

@grifball Karma don't have this option now
We had a pull request(PR) about it with long discussion.
It will be nice if you look at this PR and reanimate it

Thanks!

relates #1593

@maksimr maksimr mentioned this issue Dec 1, 2016
Closed
grifball added a commit to grifball/karma that referenced this issue Dec 3, 2016
@grifball
feat(server): Added 'listenAddress' option and updated unit tests to …
4e2d17a 
…work correctly with it

reference: karma-runner#2477
@grifball
Copy link
Contributor Author

grifball commented Dec 3, 2016

I looked at #1311 and #1214 and they both seem fine to solve this issue, so I added them in and fixed the unit tests so that the dummy web server accepts the correct arguments. I'll make a PR.

@grifball grifball mentioned this issue Dec 3, 2016
Merged
@karronoli karronoli mentioned this issue Aug 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump karma from ~1.2.0 to ~6.4 in /redpen-server karronoli/redpen
2 participants
@maksimr @grifball