feat(agents-api): Add retry policies to temporal workflows/activities #551
Conversation
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 578f473 in 13 seconds
More details
- Looked at
353lines of code in14files - Skipped
2files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. agents-api/agents_api/common/retry_policies.py:8
- Draft comment:
Consider increasingmaximum_attemptsto a higher value to improve reliability in case of transient errors. - Reason this comment was not posted:
Confidence changes required:50%
The retry policy is set to a maximum of 2 attempts, which might be too low for certain transient errors. Increasing the maximum attempts could improve reliability.
Workflow ID: wflow_oDpBmGrja17xGQsb
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on a1fb6aa in 8 seconds
More details
- Looked at
41lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. agents-api/agents_api/common/retry_policies.py:4
- Draft comment:
Ensuredebugandtestingare correctly set in all environments to avoid unintended retry behavior. Consider documenting their expected values and usage. - Reason this comment was not posted:
Confidence changes required:50%
The retry policy is well-defined, but the use ofdebugandtestingvariables should be verified for correctness and potential side effects.
Workflow ID: wflow_paEEvU7QVBqzGmRU
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Signed-off-by: Diwank Singh Tomer <[email protected]>
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on ccd01db in 10 seconds
More details
- Looked at
80lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. agents-api/agents_api/common/retry_policies.py:13
- Draft comment:
Consider reviewing the list of non-retryable error types. Some exceptions likeRuntimeErrorandValueErrormight be too generic and could potentially mask issues that are transient and should be retried. Ensure that all included exceptions are truly non-retryable in the context of your application. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_dkRayuzjgCEX0nOV
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 2d945d3 in 9 seconds
More details
- Looked at
44lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. agents-api/agents_api/workflows/task_execution/__init__.py:57
- Draft comment:
The import ofDEFAULT_RETRY_POLICYwas moved inside theworkflow.unsafe.imports_passed_through()block, which is correct. Ensure all necessary imports are within this block for Temporal workflows. - Reason this comment was not posted:
Confidence changes required:20%
The import of DEFAULT_RETRY_POLICY was moved inside the workflow.unsafe.imports_passed_through() block, which is a good practice for Temporal workflows to ensure all necessary imports are available when the workflow is executed. However, the import statement was removed from the top of the file, which is unnecessary since it is now correctly placed inside the block.
Workflow ID: wflow_cOyp7X4zLWDofvyL
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
@HamadaSalhab can you confirm that this works? Because I see string names of the error classes both direct and namespaced ( |
Important
Introduces
DEFAULT_RETRY_POLICYfor consistent retry behavior in Temporal workflows and activities, updating workflows, activities, and tests accordingly.DEFAULT_RETRY_POLICYinretry_policies.pywith specific retry configurations.DEFAULT_RETRY_POLICYtorun_task_execution_workflow()intemporal.pyandrun_embed_docs_task()increate_doc.py.retry_policy=DEFAULT_RETRY_POLICYtoDemoWorkflow,EmbedDocsWorkflow,MemRatingWorkflow,SummarizationWorkflow,TruncationWorkflow.TaskExecutionWorkflowintask_execution/__init__.pyto useDEFAULT_RETRY_POLICYfor activities.raise_complete_async()inraise_complete_async.pyto use consistent string formatting.transition()intransition.pyto useDEFAULT_RETRY_POLICY.test_activities.pyto useDEFAULT_RETRY_POLICYin workflow execution tests.This description was created by
for 2d945d3. It will automatically update as commits are pushed.