feat(agents-api): Add more common exceptions to non-retryable set

Signed-off-by: Diwank Singh Tomer <[email protected]>
julep-ai · Oct 2, 2024 · ccd01db · ccd01db
1 parent a1fb6aa
commit ccd01db
Showing 1 changed file with 43 additions and 10 deletions.
diff --git a/agents-api/agents_api/common/retry_policies.py b/agents-api/agents_api/common/retry_policies.py
@@ -2,32 +2,65 @@
 
 from temporalio.common import RetryPolicy
 from ..env import debug, testing
+
 DEFAULT_RETRY_POLICY = RetryPolicy(
     initial_interval=timedelta(seconds=1),
     backoff_coefficient=2,
     maximum_attempts=2 if debug or testing else 25,
-    maximum_interval=timedelta(seconds=10) if debug or testing else timedelta(seconds=300),
+    maximum_interval=timedelta(seconds=10)
+    if debug or testing
+    else timedelta(seconds=300),
     non_retryable_error_types=[
+        # Temporal-specific errors
         "WorkflowExecutionAlreadyStarted",
+        "temporalio.exceptions.TerminalFailure",
+        "temporalio.exceptions.CanceledError",
+        #
+        # Built-in Python exceptions
         "TypeError",
         "AssertionError",
-        "HTTPException",
         "SyntaxError",
         "ValueError",
         "ZeroDivisionError",
+        "IndexError",
+        "AttributeError",
+        "LookupError",
+        "BufferError",
+        "ArithmeticError",
+        "KeyError",
+        "NameError",
+        "NotImplementedError",
+        "RecursionError",
+        "RuntimeError",
+        "StopIteration",
+        "StopAsyncIteration",
+        "IndentationError",
+        "TabError",
+        #
+        # Unicode-related errors
+        "UnicodeError",
+        "UnicodeEncodeError",
+        "UnicodeDecodeError",
+        "UnicodeTranslateError",
+        #
+        # HTTP and API-related errors
+        "HTTPException",
+        "fastapi.exceptions.HTTPException",
+        "fastapi.exceptions.RequestValidationError",
+        "httpx.RequestError",
+        "httpx.HTTPStatusError",
+        #
+        # Asynchronous programming errors
+        "asyncio.CancelledError",
+        "asyncio.InvalidStateError",
+        "GeneratorExit",
+        #
+        # Third-party library exceptions
         "jinja2.exceptions.TemplateSyntaxError",
         "jinja2.exceptions.TemplateNotFound",
         "jsonschema.exceptions.ValidationError",
         "pydantic.ValidationError",
-        "asyncio.CancelledError",
-        "asyncio.InvalidStateError",
         "requests.exceptions.InvalidURL",
         "requests.exceptions.MissingSchema",
-        "temporalio.exceptions.TerminalFailure",
-        "temporalio.exceptions.CanceledError",
-        "fastapi.exceptions.HTTPException",
-        "fastapi.exceptions.RequestValidationError",
-        "httpx.RequestError",
-        "httpx.HTTPStatusError",
     ],
 )