Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JUJU-751] Use the watchHashes helper for WatchConfigSettingsHash in the uniter API #13838

Merged
merged 1 commit into from
Mar 15, 2022
Merged

[JUJU-751] Use the watchHashes helper for WatchConfigSettingsHash in the uniter API #13838

merged 1 commit into from
Mar 15, 2022

Conversation

manadart
Copy link
Member

Simple mechanical change.

We have a helper that can be used for watching hashes via StringsWatcher. Using it reduces code volume.

Existing unit tests verify that the behaviour is the same.

@manadart manadart added the 2.9 label Mar 15, 2022
@manadart manadart changed the title Use the watchHashes helper for WatchConfigSettingsHash in the uniter API [JUJU-751] Use the watchHashes helper for WatchConfigSettingsHash in the uniter API Mar 15, 2022
juanmanuel-tirado
juanmanuel-tirado approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@juanmanuel-tirado juanmanuel-tirado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG2M

@manadart
Copy link
Member Author

$$merge$$

@jujubot jujubot merged commit 1943edc into juju:2.9 Mar 15, 2022
@wallyworld wallyworld mentioned this pull request Mar 16, 2022
Merged
jujubot added a commit that referenced this pull request Mar 16, 2022
@jujubot
Merge pull request #13840 from wallyworld/merge-2.9-20220315
402ab39 
#13840

Merge 2.9

#13822
#13763
#13810
#13827 
#13830 
#13831 
#13833 
#13835 
#13836 
#13832 
#13838

```
# Conflicts:
# cmd/juju/application/deploy.go
# cmd/juju/application/deployer/interface.go
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanmanuel-tirado juanmanuel-tirado juanmanuel-tirado approved these changes

Assignees
No one assigned
Labels
2.9
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manadart @juanmanuel-tirado @jujubot