Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JUJU-742] Ensure we fail if a offer is not found for RemoveOfferOperation. #13832

Merged
merged 1 commit into from
Mar 15, 2022
Merged

[JUJU-742] Ensure we fail if a offer is not found for RemoveOfferOperation. #13832

merged 1 commit into from
Mar 15, 2022

Conversation

hmlanigan
Copy link
Member

Otherwise we end up panicing later on a nil pointer.

QA steps

Try to remove an offer that doesn't exist. It should return a not found, not panic.

juju remove-offer seven

Bug Reference

https://bugs.launchpad.net/juju/+bug/1964821

@hmlanigan
Ensure we fail if a offer is not found for RemoveOfferOperation.
bab28b2 
Otherwise we end up panicing later on a nil pointer.
@hmlanigan hmlanigan changed the title Ensure we fail if a offer is not found for RemoveOfferOperation. [JUJU-742] Ensure we fail if a offer is not found for RemoveOfferOperation. Mar 14, 2022
@hmlanigan
Copy link
Member Author

$$merge$$

@jujubot jujubot merged commit 9184142 into juju:2.9 Mar 15, 2022
@hmlanigan hmlanigan deleted the panic branch March 15, 2022 14:08
@wallyworld wallyworld mentioned this pull request Mar 16, 2022
Merged
jujubot added a commit that referenced this pull request Mar 16, 2022
@jujubot
Merge pull request #13840 from wallyworld/merge-2.9-20220315
402ab39 
#13840

Merge 2.9

#13822
#13763
#13810
#13827 
#13830 
#13831 
#13833 
#13835 
#13836 
#13832 
#13838

```
# Conflicts:
# cmd/juju/application/deploy.go
# cmd/juju/application/deployer/interface.go
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallyworld wallyworld wallyworld approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hmlanigan @wallyworld @jujubot