Adds remaining authorization objects to ignore. #13214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's important that the model admission operator ignores certain types of Kubernetes objects that don't perists in the etcd state. This change further adds remainder of objects that should be ignored.
wallyworld
approved these changes
Aug 4, 2021
|
|
Merged
jujubot
added a commit
that referenced
this pull request
Aug 8, 2021
#13220 Merge 2.9 #13211 Fix data race (accessing charmInfo) in TestV2CharmExitsApplicationWorker #13212 Fix retry-provisioning command #13210 Add note and todo #13209 Improve readablity of 'no prdesc not found' error message #13214 Adds remaining authorization objects to ignore #13215 Use a key-based mutex lock to download resources/agent bins once #13218 Show application data set by the remote app in show-unit output #13219 Add impish to the ubuntu series list Trivial conflicts in imports/code comments. ``` Conflicts: # apiserver/facades/client/client/client.go # apiserver/facades/schema.json # resource/resourceadapters/opener.go ``` ## QA steps See PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's important that the model admission operator ignores certain types
of Kubernetes objects that don't persist in the etcd state. This change
further adds remainder of objects that should be ignored.
QA steps
Run Kubeflow locally on microk8s. Access the dashboard and add a volume from the Kubeflow dashboard.
Also confirmed from Dom that this fixes the issue.
Bug reference
https://bugs.launchpad.net/juju/+bug/1938955