Fix retry-provisioning command #13212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallyworld
commented
Aug 4, 2021
| SetInstanceStatus(sInfo status.StatusInfo) error | ||
| } | ||
|
|
||
| func (c *Client) updateInstanceStatus(tag names.Tag, data map[string]interface{}) error { |
There was a problem hiding this comment.
moved across from apiserver/common
wallyworld
force-pushed
the
retry-provisioning-fix
branch
from
d409a40 to
79f68c7
Compare
|
|
wallyworld
force-pushed
the
retry-provisioning-fix
branch
from
79f68c7 to
5fc7851
Compare
|
|
Merged
jujubot
added a commit
that referenced
this pull request
Aug 8, 2021
#13220 Merge 2.9 #13211 Fix data race (accessing charmInfo) in TestV2CharmExitsApplicationWorker #13212 Fix retry-provisioning command #13210 Add note and todo #13209 Improve readablity of 'no prdesc not found' error message #13214 Adds remaining authorization objects to ignore #13215 Use a key-based mutex lock to download resources/agent bins once #13218 Show application data set by the remote app in show-unit output #13219 Add impish to the ubuntu series list Trivial conflicts in imports/code comments. ``` Conflicts: # apiserver/facades/client/client/client.go # apiserver/facades/schema.json # resource/resourceadapters/opener.go ``` ## QA steps See PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The juju retry-provisioning command was broken because it was updating the machine agent status, not the machine instance status when it set the "transient=true" status flag.
This PR fixes that, and also addresses a long standing issue where the facade code to do the update was in the wrong package. The update code is moved from the apiserver/common package to the client facade package.
QA steps
Hard to QA unless the provider returns an error. I hard coded the LXD provider to return an error and added a machine. AFter the provisioning failed, I ran juju retry-provisioning and saw the operation being retried using juju status.
Bug reference
https://bugs.launchpad.net/juju/+bug/1938736